Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKLOG-23520: added js module engine dependency #95

Merged
merged 1 commit into from
Jan 15, 2025
Merged

BACKLOG-23520: added js module engine dependency #95

merged 1 commit into from
Jan 15, 2025

Conversation

GauBen
Copy link
Member

@GauBen GauBen commented Jan 15, 2025

Description

Just as written on the tin

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@GauBen GauBen requested a review from dgriffon January 15, 2025 11:01
@GauBen GauBen merged commit 47a3290 into main Jan 15, 2025
5 checks passed
@GauBen GauBen deleted the GauBen-patch-1 branch January 15, 2025 11:17
@baptistegrimaud baptistegrimaud mentioned this pull request Jan 16, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgriffon dgriffon dgriffon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauBen @dgriffon