Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKLOG-23532: make login work without js #97

Merged
merged 1 commit into from
Jan 16, 2025
Merged

BACKLOG-23532: make login work without js #97

merged 1 commit into from
Jan 16, 2025

Conversation

GauBen
Copy link
Member

@GauBen GauBen commented Jan 16, 2025

Description

image

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@GauBen GauBen changed the title BACKLOG-23346: prevent server files from being imported in client bundle BACKLOG-23532: make login work without js Jan 16, 2025
@GauBen GauBen merged commit 660c2f8 into main Jan 16, 2025
5 checks passed
@GauBen GauBen deleted the BACKLOG-23532 branch January 16, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkevan jkevan jkevan approved these changes

@baptistegrimaud baptistegrimaud Awaiting requested review from baptistegrimaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauBen @jkevan