This repository was archived by the owner on Dec 6, 2025. It is now read-only.
Category support additions #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtomicAlexD
previously approved these changes
Jun 3, 2025
Will be useful for various key restraints.
Jake-Pullen
added a commit
that referenced
this pull request
Jun 28, 2025
* feat: 🆕 enhance user and category management with new routes and templates * feat: 🆕 enhance test coverage for database operations with new test cases and cleanup * feat: 🆕 add docstring to read_database method for clarity on functionality * Update src/front/home.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/front/home.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/tests/test_data_handler.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: 🆕 add tempfile import for handling temporary files in tests * fix: 🐛 add conditional check for selected_user_id before displaying category form * fix: 🐛 reorder import statements for consistency in home.py * fix: 🐛 update route name for user submission to be more descriptive * fix: 🐛 streamline user existence check and improve session handling in home.py * fix: 🐛 put the read_database back where it belongs. * fix: 🐛 add docstrings for add_user_name and get_users methods in database class * feat: add new task for fixing code with Ruff and update tasks.json; improve database methods and tests * fix: 🐛 add setting to render whitespace in editor * Category support additions (#19) * Some initial changes based on feedback * More additions * Resolved most comments from Pull Request 8 * Moved convert to universal currency to its own module. * Working towards adding default rows, need to add system user? * feat: ✨We now add an internal master category per user that is hidden Will be useful for various key restraints. * fix: 🩹 Fixed a test failure --------- Co-authored-by: Alex Dimmock <alex.d@useadam.co.uk> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jake Pullen <hello@jake-is.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Title: Category support additions, to resolve most changes requested in #8
2. Description:
3. Checklist:
[x] I have followed the project's coding style and conventions.
[x] I have written unit tests to cover my changes.
[x] My code has been tested locally.
[x] I have included screenshots/GIFs if applicable.
[x] I have updated the documentation (if necessary).
[x] I have labeled this PR appropriately (e.g., "bug," "feature," "refactor").