Skip to content
This repository was archived by the owner on Dec 6, 2025. It is now read-only.

Conversation

@AtomicAlexD
Copy link
Collaborator

@AtomicAlexD AtomicAlexD commented May 23, 2025

Pull Request Type:

1. Title: [Database v2 upgrade]
2. Description:

  • Summary: Updated the database to a v2 which should handle transactions and added tests.
  • Motivation: We planned out the DB better and delt with some issues like how we assign values to budgets.
  • Proposed Solution: Describe your solution in detail. Explain how you implemented the change. Be specific.
  • Screenshots/GIFs (if applicable): If your change involves UI changes, include screenshots or a GIF to demonstrate the impact.
  • Testing: Ran the UV tests after updating them and also managed to successfully add a new user.

3. Checklist:

[x] I have followed the project's coding style and conventions.
[x] I have written unit tests to cover my changes.
[x] My code has been tested locally.
[x] I have included screenshots/GIFs if applicable.
[x] I have updated the documentation (if necessary).
[x] I have labeled this PR appropriately (e.g., "bug," "feature," "refactor").

4. Reviewer Notes (Optional - Add if you have specific requests)

@AtomicAlexD AtomicAlexD requested a review from Copilot May 23, 2025 12:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the database schema to version 2 by replacing the budget-related functionalities with user-related ones and updating corresponding tests and UI logic.

  • Renames SQL queries, test functions, and data handler methods from budget to user.
  • Updates the home page to work with user data instead of budgets.
  • Revises the database schema YAML to add a new user table and modify foreign key relationships accordingly.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
src/tests/test_data_handler.py Updated test functions and SQL queries to reference the user table.
src/front/home.py Modified UI endpoints and flash messages to use user names.
src/data_handler.py Renamed and adjusted database functions to handle users.
src/config_files/verity_schema.yaml Updated schema definitions to include the user table and adjust foreign keys.
Files not reviewed (1)
  • src/front/templates/home.html: Language not supported
Comments suppressed due to low confidence (2)

src/front/home.py:33

  • [nitpick] Consider correcting the capitalization in the flash message to 'User name not saved, please check the logs' for consistency.
flash("user Name not saved, please check the logs", "error")

src/config_files/verity_schema.yaml:15

  • [nitpick] Ensure consistency in table naming conventions; if other tables use plural names, consider renaming 'account_type' to 'account_types' or updating others for uniformity.
- table_name: account_type

@AtomicAlexD AtomicAlexD requested a review from Jake-Pullen May 23, 2025 12:32
@AtomicAlexD AtomicAlexD marked this pull request as ready for review May 23, 2025 12:33
Copy link
Owner

@Jake-Pullen Jake-Pullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, Thanks

@AtomicAlexD AtomicAlexD merged commit d22aa1b into stage May 23, 2025
1 check passed
@AtomicAlexD AtomicAlexD deleted the Feature--Upgrading_database branch May 23, 2025 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants