Skip to content
This repository was archived by the owner on Dec 6, 2025. It is now read-only.

Conversation

@AtomicAlexD
Copy link
Collaborator

Pull Request Type:

1. Title: Updated foreign key building and adjusted default logging level

2. Description:

  • Summary: Added in foreign keys so the database has more integrity and to help with data quality.
  • Motivation: We want to have data integrity
    3. Checklist:

[x] I have followed the project's coding style and conventions.
[x] I have written unit tests to cover my changes.
[x] My code has been tested locally.
[x] I have included screenshots/GIFs if applicable.
[x] I have updated the documentation (if necessary).
[x] I have labeled this PR appropriately (e.g., "bug," "feature," "refactor").

4. Reviewer Notes (Optional - Add if you have specific requests)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the logging level and simplifies how foreign key constraints are built and referenced in the database schema.

  • Updated logging configuration from DEBUG to INFO
  • Simplified foreign key reference handling by embedding foreign key references directly in column definitions
  • Modified YAML schema to use simplified foreign key table names

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/data_handler.py Added debug logging and inlined FK reference building in column def
src/config_files/verity_schema.yaml Updated FK references to use table names only
src/config_files/logging_config.yaml Changed logging level from DEBUG to INFO

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Owner

@Jake-Pullen Jake-Pullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good 👯

@AtomicAlexD AtomicAlexD merged commit 460d7f6 into stage May 23, 2025
@AtomicAlexD AtomicAlexD deleted the fix/foreign_key_building branch May 23, 2025 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants