Skip to content

Comments

Update to latest#4

Open
ocornut wants to merge 2158 commits intoJakeCoxon:win98from
ocornut:external/win98
Open

Update to latest#4
ocornut wants to merge 2158 commits intoJakeCoxon:win98from
ocornut:external/win98

Conversation

@ocornut
Copy link

@ocornut ocornut commented Jun 7, 2024

This is a merge-commit version of #3, whichever you prefer. (I think it is neater to rebase + force-push, but you may merge it instead to save time)

ocornut and others added 30 commits January 17, 2024 15:33
Weirdly as old as when dinosaurs roamed earth, aka first commit (per-1.0).
+ Minor alignment in both sense of the term :) Reduce padding in ImGuiNextItemData.
…change (part 1)

Moved KeepAliveID() as well for increased locality.
Adding dummy ItemAdd() placeholder to facilitate diffing (otherwise single commit single diff is a mess).
…change (part 2)

Diff not ideal (in Fork it looks like ItemSize is moved) but understandable at a glance.
…VulkanSDK 1.3.275 by allocating one extra semaphore than in-flight frames. (#7236)
…f Enter key as it doesn't go through Shortcut

InputText: no need to call SetShortcutRouting() directly.
Tangential to experiments for #7237
- It doesn't sense to test route without ownership (which may be overrided by code not using routing)
- It also wouldn't be possible to call Shortcut() with _None anyway, since successful routing sets ownership.
Tangential to experiments for #7237
…compatible Desktop examples, as aiming to make this suppot desktop eventually.

Also aimed at reducing diff for #7132 tho this will lead in conflict.
…itInfo structure instead of variety of parameters, allowing for easier further changes. (#7240)
Detect polygon mode using same method as others (not define/symbol).
IMGUI_IMPL_OPENGL_MAY_HAVE_EXTENSIONS -> IMGUI_IMPL_OPENGL_HAS_EXTENSIONS
)

There are two issues here - first, this macro uses AT&T specific syntax with $, which is not necessary. Also, some assemblers (nasm) emit different bytes for "int 3" and "int3", so it's better to use "int3" (cd 03 vs cc)

More importantly, GDB has some failing assertion whenever stepping after hitting an "int3" instruction. This makes it practically useless, as is. For some reason, putting a nop afterwards as a workaround is okay.

Related discussions:
https://sourceware.org/bugzilla/show_bug.cgi?id=31194
https://lists.sr.ht/~skeeto/public-inbox/%3C2d3d7662a361ddd049f7dc65b94cecdd%40disroot.org%3E
ocornut and others added 29 commits May 29, 2024 18:48
… required solely by the presence of an horizontal scrollbar. (#1574)

Initially fixed by 2d9d7a1, and broken back by a0994d7 (v1.71, wow).
…e, previous scrollbar width would be accounted for. (#5920)

Amend 317b33d
…wouldn't correctly take account of inner scrollbar. (#7651)
…extraneous packing. rename ImGuiDataTypeTempStorage to ImGuiDataTypeStorage. moved DataType section above Widgets.
…tyRefVal, ImGuiInputTextFlags_DisplayEmptyRefVal. (#7305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.