This repository was archived by the owner on Sep 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 459
Enable two static shortcuts: record and overlay. #139
Open
JakeWharton
wants to merge
4
commits into
master
Choose a base branch
from
SimonMarquis-feature/static_shortcuts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
740fb76
Enable two static shortcuts: record and overlay.
SimonMarquis f1a99be
Fix drawable resource name
SimonMarquis e218e59
Add debug version of shortcuts as explained in #135 and #139
SimonMarquis 561b0e6
Merge pull request #141 from SimonMarquis/SimonMarquis-feature/static…
JakeWharton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <shortcuts | ||
| xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| tools:targetApi="n_mr1" | ||
| > | ||
| <shortcut | ||
| android:enabled="true" | ||
| android:icon="@drawable/ic_shortcut_overlay_48dp" | ||
| android:shortcutDisabledMessage="@string/launch" | ||
| android:shortcutId="overlay" | ||
| android:shortcutLongLabel="@string/launch_telecine" | ||
| android:shortcutShortLabel="@string/launch" | ||
| > | ||
| <intent | ||
| android:action="com.jakewharton.telecine.STATIC_SHORTCUT_OVERLAY" | ||
| android:targetClass="com.jakewharton.telecine.TelecineShortcutLaunchActivity" | ||
| android:targetPackage="com.jakewharton.telecine.debug" | ||
| > | ||
| <extra | ||
| android:name="launch-action" | ||
| android:value="Static Shortcut Overlay" | ||
| /> | ||
| </intent> | ||
| <categories android:name="android.shortcut.conversation"/> | ||
| </shortcut> | ||
| <shortcut | ||
| android:enabled="true" | ||
| android:icon="@drawable/ic_shortcut_record_48dp" | ||
| android:shortcutDisabledMessage="@string/record" | ||
| android:shortcutId="record" | ||
| android:shortcutLongLabel="@string/start_recording" | ||
| android:shortcutShortLabel="@string/record" | ||
| > | ||
| <intent | ||
| android:action="com.jakewharton.telecine.STATIC_SHORTCUT_RECORD" | ||
| android:targetClass="com.jakewharton.telecine.TelecineShortcutLaunchActivity" | ||
| android:targetPackage="com.jakewharton.telecine.debug" | ||
| > | ||
| <extra | ||
| android:name="launch-action" | ||
| android:value="Static Shortcut Record" | ||
| /> | ||
| <extra | ||
| android:name="auto-recording" | ||
| android:value="true" | ||
| /> | ||
| </intent> | ||
| <categories android:name="android.shortcut.conversation"/> | ||
| </shortcut> | ||
| </shortcuts> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,8 @@ interface Analytics { | |
| String ACTION_QUICK_TILE_ADDED = "Quick Tile Added"; | ||
| String ACTION_QUICK_TILE_LAUNCHED = "Quick Tile Launched"; | ||
| String ACTION_QUICK_TILE_REMOVED = "Quick Tile Removed"; | ||
| String ACTION_STATIC_SHORTCUT_RECORD = "Static Shortcut Record"; | ||
| String ACTION_STATIC_SHORTCUT_OVERLAY = "Static Shortcut Overlay"; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these are unused... |
||
|
|
||
| String VARIABLE_RECORDING_LENGTH = "Recording Length"; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
telecine/src/main/res/drawable/ic_shortcut_overlay_48dp.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="48dp" | ||
| android:height="48dp" | ||
| android:viewportHeight="49.333336" | ||
| android:viewportWidth="49.333336"> | ||
| <path | ||
| android:fillAlpha="1" | ||
| android:fillColor="#f5f5f5" | ||
| android:pathData="M24.67,24.67m-22,0a22,22 0,1 1,44 0a22,22 0,1 1,-44 0" /> | ||
| <path | ||
| android:fillAlpha="1" | ||
| android:fillColor="#e73c35" | ||
| android:pathData="m31.42,17.92 l-13.5,0c-0.82,0 -1.5,0.68 -1.5,1.5l0,10.5c0,0.82 0.68,1.5 1.5,1.5l13.5,0c0.82,0 1.5,-0.68 1.5,-1.5l0,-10.5c0,-0.82 -0.68,-1.5 -1.5,-1.5zM31.42,29.92 L17.92,29.92 17.92,19.42 25.42,19.42 25.42,22.42 31.42,22.42 31.42,29.92z" /> | ||
| </vector> |
14 changes: 14 additions & 0 deletions
14
telecine/src/main/res/drawable/ic_shortcut_record_48dp.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="48dp" | ||
| android:height="48dp" | ||
| android:viewportHeight="49.333336" | ||
| android:viewportWidth="49.333336"> | ||
| <path | ||
| android:fillAlpha="1" | ||
| android:fillColor="#f5f5f5" | ||
| android:pathData="M24.67,24.67m-22,0a22,22 0,1 1,44 0a22,22 0,1 1,-44 0" /> | ||
| <path | ||
| android:fillAlpha="1" | ||
| android:fillColor="#e73c35" | ||
| android:pathData="m29.67,23.17 l0,-3.5c0,-0.55 -0.45,-1 -1,-1l-12,0c-0.55,0 -1,0.45 -1,1l0,10c0,0.55 0.45,1 1,1l12,0c0.55,0 1,-0.45 1,-1l0,-3.5 4,4 0,-11 -4,4z" /> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <!-- Static shortcuts are used on API 25 instead. --> | ||
| <bool name="widget_shortcut_enabled">false</bool> | ||
| </resources> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <bool name="widget_shortcut_enabled">true</bool> | ||
| </resources> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.