-
Notifications
You must be signed in to change notification settings - Fork 133
Always self-update the SDK tools before installing build tools #111
Conversation
|
Hi, Thanks |
|
Confirmed. I was assuming the |
As it not only holds the major version, but the full version number.
The package names are listed in double-quotes, so match for them, too, to be on the safe side when filtering for more generic package names like "tools". Credits go to @rusmonster's PR #87: https://github.com/JakeWharton/sdk-manager-plugin/pull/87/files#diff-4b3adef258cd0701e1810b6e3e58d2cbL69
|
@pelegb Would you mind trying the force-pushed update to this PR? |
|
@sschuberth it doesn't seem to solve the issue. The tools are being updated in each subproject and in each build. Thanks for the quick response. |
This is a preparation for later reuse. Credits go to @rusmonster's PR #87: https://github.com/JakeWharton/sdk-manager-plugin/pull/87/files#diff-ee864a377f9eb3669513adf57ed40e7bL226
|
@pelegb Thanks for checking, I believe to have found the issue. Please try again with the new force-pushed version. |
|
@sschuberth I'm receiving "No SDK tools available for update." in subsequent builds. Strange. |
|
I think I found the issue, you need to use listAll instead of listUpdate android command because once installed the tools don't appear in the list anymore |
|
Why is that an issue? I'd say it works as expected. Once the latest SDK tools have been installed, they naturally are not available for update anymore. |
|
Your correct. Thanks |
|
So can you confirm it's working correctly for you now? |
|
Yes |
|
Great, thanks for checking! |
|
Closing this as the Android Gradle plugin 2.2.0 has this feature built-in and this whole project is deprecated now. |
This is more or less a simplified version of PRs #87, #44, #41, #37, in the sense that it always self-updates the SDK tools before installing the build tools, and does so after resolving the platform tools. The latter is necessary as the SDK tools depend on the platform tools, and resolving the SDK tools first would result in an error like
This PR fixes a bunch of issues, mainly issue #43, but also issue #101 and related ones.