Replace Swiss Ephemeris stub and update provider messaging#6
Replace Swiss Ephemeris stub and update provider messaging#6Jakedoes1111 wants to merge 3 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const PLANETS: Array<{ id: string; body: Body }> = [ | ||
| { id: "Sun", body: Body.Sun }, | ||
| { id: "Earth", body: Body.Earth }, | ||
| { id: "Moon", body: Body.Moon }, | ||
| { id: "Mercury", body: Body.Mercury }, | ||
| { id: "Venus", body: Body.Venus }, | ||
| { id: "Mars", body: Body.Mars }, | ||
| { id: "Jupiter", body: Body.Jupiter }, | ||
| { id: "Saturn", body: Body.Saturn }, | ||
| { id: "Uranus", body: Body.Uranus }, | ||
| { id: "Neptune", body: Body.Neptune }, | ||
| { id: "Pluto", body: Body.Pluto }, | ||
| ]; | ||
|
|
||
| const wrapDegrees = (value: number) => { | ||
| const mod = value % 360; | ||
| return mod < 0 ? mod + 360 : mod; | ||
| }; | ||
|
|
||
| const computeLongitude = (date: DateTime, body: Body): number => { | ||
| const vector = GeoVector(body, MakeTime(date.toUTC().toJSDate()), true); | ||
| const ecliptic = Ecliptic(vector); |
There was a problem hiding this comment.
The HumanDesignGateProvider iterates PLANETS including Body.Earth and feeds each entry directly to GeoVector. For Earth this call returns the observer’s own location (a zero vector), so computeLongitude always produces 0°, meaning the Earth gate is permanently resolved as Gate 1 and the G‑centre is marked defined for every chart. This causes type/authority derivations to be wrong for anyone whose G‑centre should be undefined (e.g. Reflectors), regardless of birth data. The provider should derive the Earth’s gate from the Sun’s longitude (180° opposite) or omit Earth entirely rather than asking Astronomy Engine for Earth’s geocentric coordinates.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_690c4e61d8ec832d8426ed0e00b1feff