Crud School [Data and Domain] #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jvcanavarro
commented
Dec 24, 2020
jvcanavarro
commented
renan-cunha
requested changes
Dec 24, 2020
Member
renan-cunha
left a comment
renan-cunha
left a comment
There was a problem hiding this comment.
I think ClassroomModel should be updated with a foreign key of school
| try { | ||
| bool nullToAbsent = true; | ||
| final schoolCompanion = schoolModel.toCompanion(nullToAbsent); | ||
| final classPk = await this.database.insertSchool(schoolCompanion); |
Member
There was a problem hiding this comment.
this parameter should be something like schoolPk
| import 'package:flutter/cupertino.dart'; | ||
| import 'package:flutter/foundation.dart'; | ||
|
|
||
| enum Modality { municipal, estadual, federal, privada } |
Member
There was a problem hiding this comment.
In doubt if these categories should be spelled in English
Member
Author
There was a problem hiding this comment.
yeah, i just copied from backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.