Filtering the response from EbayAPI #34 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save to local database as well in PostgreSQL
gmanhas12
requested review from
AbhiDoshi2000,
James-Cheaper,
Urbanmisfit90,
dendenso,
forz-man,
jeanahan,
johnnvij and
sridhar852002
James-Cheaper
approved these changes
Jun 16, 2025
Owner
James-Cheaper
left a comment
James-Cheaper
left a comment
There was a problem hiding this comment.
please fetch and then pull from the primary branch to make sure your branch is up to date
forz-man
approved these changes
Jun 18, 2025
Collaborator
forz-man
left a comment
forz-man
left a comment
There was a problem hiding this comment.
Good refactor: search_item returns a list of EbayItems with richer data. Tests added for API errors and empty responses — nice work. Suggest using a custom exception instead of generic Exception. Consider parsing itemCreationDateinto adatetime` object.
jeanahan
approved these changes
Jun 18, 2025
…to GagansBranch
jeanahan
pushed a commit
that referenced
this pull request
Jul 4, 2025
* Retrieve a item from Ebay api * fixed main.py so it runs, made minor changes, updated readme on how to run * fixed to use real api now from ebay * fixed issues, used ORM instead of dict, made it save to local database as well in PostgreSQL * removed pyc files * fixed error * used orm instead of dict * fixed small error everything good now * adressed all recent comments * Addresed comments * Filtering the response from EbayAPI #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue 34