-
Notifications
You must be signed in to change notification settings - Fork 0
docs: document auto-versioning workflow chain #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Three workflows chain via repository_dispatch: 1. detect-plugin-changes - detects changes, analyzes bump type 2. bump-plugin-versions - bumps versions, commits 3. create-release-tags - creates git tags Bump type determined from PR labels or conventional commits. Requires VERSION_PAT secret for workflow chaining. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da2958b682
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Get changed files between HEAD and HEAD~1 | ||
| CHANGED_FILES=$(git diff --name-only HEAD~1 HEAD 2>/dev/null || git diff --name-only HEAD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detect all commits in push, not just HEAD~1
The change detection only diffs HEAD~1..HEAD, which misses files changed earlier in the same push (e.g., a rebase/merge that lands multiple commits on main). In that case the workflow will see only the last commit’s files and may skip version bumps for plugins touched in earlier commits, leaving versions stale. Consider diffing the full push range (e.g., github.event.before..github.sha) to cover all commits in the push.
Useful? React with 👍 / 👎.
| token: ${{ secrets.VERSION_PAT }} | ||
| fetch-depth: 0 # Need full history for proper tagging | ||
| ref: main # Ensure we're on latest main with version bump commit | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag the bump commit, not current main
This workflow checks out and pulls main, but never checks out the commit_sha passed in the dispatch payload. If another commit lands on main between the bump commit and this workflow running, the tags will be created on the newer HEAD instead of the bump commit that produced the versions. That can tag the wrong code. Consider checking out the specific commit_sha before tagging.
Useful? React with 👍 / 👎.
Previously only checked HEAD~1, missing changes in earlier commits when multiple commits pushed together. Now uses github.event.before to capture full push range. Fixes codex review comment on PR #25. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously tagged HEAD after git pull, which could include commits that landed after the version bump. Now explicitly tags the commit_sha from the workflow dispatch payload. Fixes codex review comment on PR #25. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Test plan
gh secret list)🤖 Generated with Claude Code