Skip to content

Commit

Permalink
James.yang/fix setup (#45)
Browse files Browse the repository at this point in the history
* Modify is_glue_eq for simpler specialization

* Update CHANGELOG

* Add list of third-party tools

* Remove one newline
  • Loading branch information
JamesYang007 authored Dec 24, 2019
1 parent 38f1492 commit c6e38c0
Show file tree
Hide file tree
Showing 3 changed files with 65 additions and 8 deletions.
51 changes: 51 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Changelog

## [v1.0.0](https://github.com/JamesYang007/FastAD/tree/v1.0.0) (2019-12-24)

[Full Changelog](https://github.com/JamesYang007/FastAD/compare/9a33ff57b96985752aff80b24e554d1de5fdcb1f...v1.0.0)

**Closed issues:**

- ad::constant not compatible with type T=ForwardVar\<double\> [\#26](https://github.com/JamesYang007/FastAD/issues/26)
- Var\<T\> move constructor implementation [\#19](https://github.com/JamesYang007/FastAD/issues/19)
- ProdNode can feval and beval be separated? [\#18](https://github.com/JamesYang007/FastAD/issues/18)
- Benchmark should use googlebenchmark [\#17](https://github.com/JamesYang007/FastAD/issues/17)
- Remove armadillo dependency [\#16](https://github.com/JamesYang007/FastAD/issues/16)
- Remove CRTP and Replace with Concepts [\#13](https://github.com/JamesYang007/FastAD/issues/13)
- Reduce standard to C++14 [\#12](https://github.com/JamesYang007/FastAD/issues/12)

**Merged pull requests:**

- Remove dollar sign from shell [\#44](https://github.com/JamesYang007/FastAD/pull/44) ([JamesYang007](https://github.com/JamesYang007))
- Fix table of contents [\#43](https://github.com/JamesYang007/FastAD/pull/43) ([JamesYang007](https://github.com/JamesYang007))
- Fix indentation of lists in README [\#42](https://github.com/JamesYang007/FastAD/pull/42) ([JamesYang007](https://github.com/JamesYang007))
- Add mkdir only if build does not exist in benchmark [\#41](https://github.com/JamesYang007/FastAD/pull/41) ([JamesYang007](https://github.com/JamesYang007))
- James.yang/benchmark [\#40](https://github.com/JamesYang007/FastAD/pull/40) ([JamesYang007](https://github.com/JamesYang007))
- Update installation directions and FAQ [\#39](https://github.com/JamesYang007/FastAD/pull/39) ([JamesYang007](https://github.com/JamesYang007))
- Pilot 2.1/remove arma [\#38](https://github.com/JamesYang007/FastAD/pull/38) ([JamesYang007](https://github.com/JamesYang007))
- Pilot 2.1/remove arma [\#35](https://github.com/JamesYang007/FastAD/pull/35) ([JamesYang007](https://github.com/JamesYang007))
- James.yang/concepts [\#34](https://github.com/JamesYang007/FastAD/pull/34) ([JamesYang007](https://github.com/JamesYang007))
- James.yang/docs [\#32](https://github.com/JamesYang007/FastAD/pull/32) ([JamesYang007](https://github.com/JamesYang007))
- James.yang/docs [\#31](https://github.com/JamesYang007/FastAD/pull/31) ([JamesYang007](https://github.com/JamesYang007))
- Add index.html [\#30](https://github.com/JamesYang007/FastAD/pull/30) ([JamesYang007](https://github.com/JamesYang007))
- Remove boost completely in CMake [\#29](https://github.com/JamesYang007/FastAD/pull/29) ([JamesYang007](https://github.com/JamesYang007))
- Kent.hall/matrix [\#27](https://github.com/JamesYang007/FastAD/pull/27) ([kentjhall](https://github.com/kentjhall))
- James.yang/remove boost [\#25](https://github.com/JamesYang007/FastAD/pull/25) ([JamesYang007](https://github.com/JamesYang007))
- Add -Wextra for stricter build [\#23](https://github.com/JamesYang007/FastAD/pull/23) ([JamesYang007](https://github.com/JamesYang007))
- Change API for jacobian and hessian [\#22](https://github.com/JamesYang007/FastAD/pull/22) ([JamesYang007](https://github.com/JamesYang007))
- Pilot 2.0/minor [\#21](https://github.com/JamesYang007/FastAD/pull/21) ([JamesYang007](https://github.com/JamesYang007))
- Fix minor typos and issues [\#20](https://github.com/JamesYang007/FastAD/pull/20) ([JamesYang007](https://github.com/JamesYang007))
- Fully refactored version 2.0 [\#10](https://github.com/JamesYang007/FastAD/pull/10) ([JamesYang007](https://github.com/JamesYang007))
- Refactor advec, indent fix adnode, robustness clean-build [\#9](https://github.com/JamesYang007/FastAD/pull/9) ([JamesYang007](https://github.com/JamesYang007))
- Add build for example [\#8](https://github.com/JamesYang007/FastAD/pull/8) ([JamesYang007](https://github.com/JamesYang007))
- Fix structure and move fastad as the only exported header [\#7](https://github.com/JamesYang007/FastAD/pull/7) ([JamesYang007](https://github.com/JamesYang007))
- Add comments to admath and modify clean-build [\#6](https://github.com/JamesYang007/FastAD/pull/6) ([JamesYang007](https://github.com/JamesYang007))
- Add better comments in dualnum and utility [\#5](https://github.com/JamesYang007/FastAD/pull/5) ([JamesYang007](https://github.com/JamesYang007))
- Add better comments in adforward.hpp [\#4](https://github.com/JamesYang007/FastAD/pull/4) ([JamesYang007](https://github.com/JamesYang007))
- Add better comments to adeval and simplify structure [\#3](https://github.com/JamesYang007/FastAD/pull/3) ([JamesYang007](https://github.com/JamesYang007))
- Restructure include directory and updated tests [\#2](https://github.com/JamesYang007/FastAD/pull/2) ([JamesYang007](https://github.com/JamesYang007))
- Fix multithreading to use boost thread\_pool in adeval [\#1](https://github.com/JamesYang007/FastAD/pull/1) ([JamesYang007](https://github.com/JamesYang007))



\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
- [Hessian](#hessian)
- [Contact](#contact)
- [Team](#team)
- [Third Party Tools](#third-party-tools)
- [License](#license)

## Overview
Expand Down Expand Up @@ -288,6 +289,18 @@ feel free to [send me an email](mailto:jamesyang916@gmail.com).
| [![JamesYang007](https://avatars3.githubusercontent.com/u/5008832?s=100&v=4)](https://github.com/JamesYang007) | [](https://github.com/kentjhall) |
| <a href="http://github.com/JamesYang007" target="_blank">`github.com/JamesYang007`</a> | <a href="http://github.com/kentjhall" target="_blank">`github.com/kentjhall`</a> |

## Third Party Tools

Many third party tools were used for this project.

- [Clang](https://clang.llvm.org/): main compiler used for development.
- [Codacy](https://app.codacy.com/welcome/organizations): rigorous code analysis.
- [Github Changelog Generator](https://github.com/github-changelog-generator/github-changelog-generator): generate [CHANGELOG](https://github.com/JamesYang007/FastAD/blob/master/CHANGELOG.md).
- [Google Benchmark](https://github.com/google/benchmark): benchmark against various methods.
- [Googletest](https://github.com/google/googletest): unit-test and integration-test.
- [Travis](https://travis-ci.org/): continuous integration for Linux.
- [Valgrind](http://valgrind.org/): check memory leak/error.

## License

- **[MIT license](http://opensource.org/licenses/mit-license.php)**
Expand Down
9 changes: 1 addition & 8 deletions include/fastad_bits/node.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -329,17 +329,10 @@ struct glue_size
template <class ValueType, class LeftExprType, class ExprType>
struct glue_size<GlueNode<ValueType, LeftExprType, EqNode<ValueType, ExprType>>>
{
static_assert(is_glue_eq<LeftExprType>::value, "Left expression is not a GlueNode.");
static inline constexpr size_t value = 1 + glue_size<LeftExprType>::value;
};

template <class ValueType, class ExprType1, class ExprType2>
struct glue_size<
GlueNode<ValueType, EqNode<ValueType, ExprType1>, EqNode<ValueType, ExprType2>>
>
{
static inline constexpr size_t value = 2;
};

template <class ValueType, class ExprType1>
struct glue_size<EqNode<ValueType, ExprType1>>
{
Expand Down

0 comments on commit c6e38c0

Please sign in to comment.