-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-fido2): add support for isEnterpriseAttestation in local me… #9521
feat(jans-fido2): add support for isEnterpriseAttestation in local me… #9521
Conversation
…tadata retrieval Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
DryRun Security SummaryThe pull request focuses on improving the reliability and security of the FIDO2 attestation process in the Jans FIDO2 server application, including enterprise attestation configuration, fallback to empty metadata, handling of metadata formats, and fallback to local root certificates, along with new test cases to ensure the robustness of the FIDO2 authentication process. Expand for full summarySummary: The code changes in this pull request focus on improving the reliability and security of the FIDO2 attestation process in the Jans FIDO2 server application. The key changes include:
The changes also include new test cases that cover the enterprise attestation feature and the handling of attestation certificates, which are important security-related aspects of the FIDO2 authentication process. These tests help to ensure the reliability and robustness of the FIDO2 server application. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Note: This pull request is dependent on [PR #9463] so its need to be merged first |
#9521) * feat(jans-fido2): add support for isEnterpriseAttestation in local metadata retrieval Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * feat(jans-fido2): add new unit test for isEnterpriseAttestation Signed-off-by: imran-ishaq <imranishaq024@gmail.com> --------- Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
…tadata retrieval
Prepare
Description
Target issue
closes #8909
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.