Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE-REQUEST]: Websocket via channels[daphne] #1207

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[FEATURE-REQUEST]: Websocket via channels[daphne] #1207

merged 2 commits into from
Nov 8, 2023

Conversation

amadolid
Copy link
Collaborator

@amadolid amadolid commented Aug 7, 2023 •
edited
Loading

CHANGES:

  • Unit test and docs are included

@amadolid amadolid force-pushed the feature-request/websocket branch 6 times, most recently from 32f5c87 to 82d2e07 Compare August 14, 2023 10:59
@amadolid amadolid changed the title [WIP][FEATURE-REQUEST]: Websocket via channels[daphne] [FEATURE-REQUEST]: Websocket via channels[daphne] Aug 14, 2023
@amadolid amadolid marked this pull request as ready for review August 14, 2023 11:03
@ypkang ypkang self-requested a review August 30, 2023 14:01
@amadolid amadolid force-pushed the feature-request/websocket branch from cd60106 to 30600ba Compare August 30, 2023 20:02
@amadolid amadolid force-pushed the feature-request/websocket branch from 30600ba to 1e71801 Compare September 11, 2023 13:19
@amadolid
Copy link
Collaborator Author

image

@amadolid
Copy link
Collaborator Author

image

ypkang
ypkang reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. I want to manually test this before merging since this changes from wsgi to asgi.

@amadolid amadolid force-pushed the feature-request/websocket branch from e19e1ac to f5ab3bb Compare November 7, 2023 13:44
marsninja
marsninja approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@marsninja marsninja merged commit 36b9b89 into Jaseci-Labs:main Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypkang ypkang ypkang left review comments

@marsninja marsninja marsninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amadolid @ypkang @marsninja