Test to diagnosis syntax error in impl file #1299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugesan1105
changed the title
marsninja
requested changes
Oct 7, 2024
jac/jaclang/langserve/engine.py
Outdated
| @@ -80,23 +80,28 @@ def update_modules( | |||
| impl_parent=self.modules[file_path], | |||
| ) | |||
|
|
|||
| def quick_check(self, file_path: str) -> bool: | |||
| def quick_check(self, file_path: str) -> tuple[bool, list[lspt.Diagnostic]]: | |||
There was a problem hiding this comment.
Not a fan of returning a tuple here just for the purpose of test case checking.
can you use the hover possition strategy for checking as in other tests?
There was a problem hiding this comment.
@kugesan1105 let me know if that works, the lsp.Position type stuff in the hover tests.
This reverts commit 2a96447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description