Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Savable Object #1442

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[FEATURE]: Savable Object #1442

merged 3 commits into from
Nov 27, 2024

Conversation

amadolid
Copy link
Collaborator

@amadolid amadolid commented Nov 13, 2024

Support ObjectAnchor/ObjectArchitype saving similar to Node/Edge/Walker

Copy link
Contributor

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amadolid can you add some descriptions on what this PR does?

@ypkang
Copy link
Contributor

ypkang commented Nov 15, 2024

  • Should also support shelf/jaclang
  • revisit the get saved object with &

@amadolid amadolid force-pushed the feature/savable-object branch 3 times, most recently from 6f67a8a to a00330e Compare November 20, 2024 09:57
jac-cloud/jac_cloud/tests/simple_graph.jac Outdated Show resolved Hide resolved
jac-cloud/jac_cloud/tests/simple_graph.jac Outdated Show resolved Hide resolved
jac-cloud/jac_cloud/tests/simple_graph.jac Outdated Show resolved Hide resolved
@amadolid amadolid force-pushed the feature/savable-object branch from 4983a71 to 88a85ca Compare November 20, 2024 16:59
@amadolid amadolid requested a review from ypkang November 20, 2024 17:02
@amadolid amadolid force-pushed the feature/savable-object branch from 88a85ca to 34277b9 Compare November 26, 2024 10:20
@ypkang ypkang merged commit 2f7b5bc into main Nov 27, 2024
4 of 5 checks passed
@ypkang ypkang deleted the feature/savable-object branch November 27, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants