Open
Conversation
kechinvv
reviewed
Sep 30, 2025
| // Running 10 iterations | ||
| for (int i = 0; i < 10; i++) { | ||
| // Generating random nums | ||
| int programmersCount = rand.nextInt(MAX); |
There was a problem hiding this comment.
Предлагаю сделать конфиг не рандомом и не хардкодом, чтобы можно было легко менять без рекомпила
Author
There was a problem hiding this comment.
Исправил, теперь значения лежат в конфиге
| @Override | ||
| public void run() { | ||
| try { | ||
| while (true) { |
There was a problem hiding this comment.
Кажется можно переписать так, чтобы не торчало while true
Author
There was a problem hiding this comment.
Исправил, теперь цикл выглядит так:
@Override
public void run() {
try {
// Trying to eat while food is here
while (!forks.isEmpty() && takeOnePortionIfAvailable()) {
boolean ate = false;
// Trying while the programmer eat
while (!ate) {
// If grabbed forks - eat
if (grabForks()) {
try {
EatDinnder();
ate = true;
} finally {
ReleaseForks();
}
} else {
Thread.sleep(50);
}
}
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
```
| import java.util.concurrent.atomic.AtomicInteger; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
|
|
||
| public class Programmer extends Thread { |
There was a problem hiding this comment.
Как будто делать все это на голых тредах плохая идея, столько всяких штук на лекции и практики рассмотрели...
There was a problem hiding this comment.
Как у вас обеспечивается равномерность поедания? В текущей реализации кажется, что чем шире будет диапазон рандома времени поедания, тем больше будет разброс накормленности
Author
There was a problem hiding this comment.
Но по крайней мере это получилось. Да с равномерностью были в некоторых случаях проблемы,
проанализировав пришел к двум выводам:
- Нужно использовать лок вместо синхронайза
- Не забирать из хэшмапа вилки
- Убрать из EatDinnder sleep с рандомным шумом
После этого результаты стали такие:
П - Программисты, ПЕ - порций еды
50П, 150ПЕ:
--------------------------------------------------------------------
Programmers: 50
Food: 150
Dinner is over!
Food amount is 0
Portions eaten: 1, Count: 3
Portions eaten: 2, Count: 12
Portions eaten: 3, Count: 23
Portions eaten: 4, Count: 7
Portions eaten: 5, Count: 4
Portions eaten: 6, Count: 1
-----------------------------
50П, 100ПЕ:
--------------------------------------------------------------------
Programmers: 50
Food: 100
Dinner is over!
Food amount is 0
Portions eaten: 1, Count: 9
Portions eaten: 2, Count: 32
Portions eaten: 3, Count: 9
--------------------------------------------------------------------
50П, 50ПЕ:
--------------------------------------------------------------------
Programmers: 50
Food: 50
Dinner is over!
Food amount is 0
Portions eaten: 1, Count: 50
--------------------------------------------------------------------
Author
There was a problem hiding this comment.
50П 750ПЕ
--------------------------------------------------------------------
Programmers: 50
Food: 750
Dinner is over!
Food amount is 0
Portions eaten: 8, Count: 1
Portions eaten: 11, Count: 1
Portions eaten: 12, Count: 7
Portions eaten: 13, Count: 9
Portions eaten: 14, Count: 10
Portions eaten: 15, Count: 7
Portions eaten: 16, Count: 6
Portions eaten: 17, Count: 2
Portions eaten: 18, Count: 2
Portions eaten: 19, Count: 1
Portions eaten: 21, Count: 2
Portions eaten: 28, Count: 1
Portions eaten: 30, Count: 1
Author
There was a problem hiding this comment.
Получается что при небольших значениях, все едят одинаково,
При огромных значениях большинство есть одинаково, аномальные выбросы есть, но они единичны
Все остаются сытыми
| while (!ate) { | ||
| // If successfully grabbed forks | ||
| // - eat | ||
| if (grabForks(this.forks)) { |
There was a problem hiding this comment.
Какой то страшный каскад всего подряд, еще и вложенные циклы. Постарайтесь пж отрефакторить, чтобы выглядело поаккуратнее
Author
|
Внес все правки о которых вы говорили, так же добавил семафор. Получился намного меньше разброс |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.