Fr] create and fill the localization ua.properties file #81 #101
Fr] create and fill the localization ua.properties file #81 #101DenysBurduzhan wants to merge 2 commits intomainfrom
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
1 similar comment
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
| <version>1</version> | ||
| </dependency> | ||
|
|
||
| </dependencies> |
There was a problem hiding this comment.
Нащо це тут? Схоже він ніде не використовуєтся.
| @Override | ||
| LocalizationService localizationService = new LocalizationService(Locale.getDefault()); | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Це не сюди, це треба зробити у класі PhoneBookContext. Також ти встановлюєш локаль з стстеми, а в нас заплановано що локаль вибирає користувач і зберігає у файлі налаштувань. отже локаль треба взяти звідти.
| .addSubcommand("command.list", getBean(ListContacts.class)) | ||
| .addSubcommand("command.user", getBean(SetUser.class)) | ||
| .addSubcommand("command.locale", getBean(SetLocale.class)) | ||
| .execute(args); |
There was a problem hiding this comment.
Це не текст для користвача це назви команд для picocli їх не треба перекладати. Думаю так воно не заведется.
| localizationService.setLocale(new Locale(newLocale)); | ||
| System.out.println(localizationService.getMessage("success.locale.changed").replace("{0}", newLocale)); | ||
| System.out.println(localizationService.getMessage("locale.current").replace("{0}", newLocale)); | ||
| return 0; |
There was a problem hiding this comment.
ОК. хоча програма закінчить роботу після виконання цєї команди. Чи є потреба міняти поточну локаль?
| locale.current=Поточна мова: {0} | ||
| locale.available=Доступні мови: {0} | ||
|
|
||
|
|
There was a problem hiding this comment.
ОК . Але це тільки маленький шматочек тут потрібно внести всі тексти для користувача.
2 participants
No description provided.