#67+#141 Implement Authentication Service and DB versioning with Flyway #145

crazyrokr · 2025-12-20T12:12:53Z

The main goal of the PR is to prepare a module and class structures covering the most common authentication mechanisms, so it introduces the following entities:

AuthRequest is a DTO containing all necessary authentication data
AuthenticationService allows to authenticate incoming AuthRequest
AuthenticationProvider provides an authentication mechanism (Basic, X509, JWT, etc.)
CredentialsSource provides access to different authentication data storages (file, database, network, etc.)

# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/service/acl/AclRulesLoader.groovy # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java

…nto feature/142-integrate-acl-groovy-based-engine-part-2

…ate-acl-groovy-based-engine-part-2

# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/acl/groovy/dsl/loader/AclRulesLoader.groovy

…ing-with-flyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

# Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

…lyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

…ing-with-flyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

authentication-api/src/main/java/javasabr/mqtt/auth/api/MqttCredentials.java

base/src/main/java/javasabr/mqtt/base/util/PropertyAssert.java

...e/src/main/java/javasabr/mqtt/auth/service/config/DatabaseCredentialsSourceSpringConfig.java

JavaSaBr · 2026-01-13T05:59:29Z

...e/src/main/java/javasabr/mqtt/auth/service/config/DatabaseCredentialsSourceSpringConfig.java

+  @Bean(initMethod = "migrate")
+  Flyway credentialsSourceFlyway(
+      DatabaseConnectionProperties databaseCredentialsSourceProperties,
+      DatabaseCredentials adminDatabaseCredentials) {


Where do we define 'adminDatabaseCredentials'?

At the moment it's defined for tests javasabr.mqtt.broker.application.service.DatabaseTestSpringConfig#adminDatabaseCredentials. Let's work on secret storage within a separate ticket

@crazyrokr on your branch I cannot start the broker app:
Factory method 'authenticationService' threw exception with message: Authenticator providers are not configured

...ce/src/test/groovy/javasabr/mqtt/broker/application/service/AuthenticationServiceTest.groovy

authentication-service/src/test/resources/log4j2.xml

JavaSaBr · 2026-01-13T06:05:03Z

...source-db/src/main/java/javasabr/mqtt/auth/credentials/source/DatabaseCredentialsSource.java

+
+  @SuppressWarnings("SqlNoDataSourceInspection")
+  private static final String CREDENTIALS_QUERY = """
+      SELECT COUNT(*) > 0


why count? not just exists?

Boolean type is not supported by all databases, so the query was rewritten without it

…didate

...ntication-service/src/main/java/javasabr/mqtt/auth/service/DefaultAuthenticationService.java

...ice/src/test/groovy/javasabr/mqtt/broker/application/service/IntegrationSpecification.groovy

...rvice/src/test/groovy/javasabr/mqtt/broker/application/service/DatabaseTestSpringConfig.java

JavaSaBr · 2026-01-14T18:17:33Z

...rvice/src/test/groovy/javasabr/mqtt/broker/application/service/DatabaseTestSpringConfig.java

+  }
+
+  @Bean(initMethod = "start", destroyMethod = "stop")
+  public PostgreSQLContainer postgreSQLContainer() {


You can define in test-support module the spring config like 'PostgresTestContainerSpringConfig' to reuse it later in the app module for example

...rvice/src/test/groovy/javasabr/mqtt/broker/application/service/DatabaseTestSpringConfig.java

authentication-api/src/main/java/javasabr/mqtt/auth/api/file/FileProperties.java

...ntication-service/src/main/java/javasabr/mqtt/auth/service/DefaultAuthenticationService.java

JavaSaBr · 2026-01-14T19:31:59Z

authentication-api/src/main/java/javasabr/mqtt/auth/api/MqttCredentials.java

+    byte[] authenticationData) {
+
+  public boolean isAnonymous() {
+    return StringUtils.isEmpty(username) && ArrayUtils.isEmpty(password);


What about the case with empty username and not empty password?

JWT authentication provider will handle such case

...e/src/main/java/javasabr/mqtt/auth/service/config/DatabaseCredentialsSourceSpringConfig.java

JavaSaBr · 2026-01-14T19:33:58Z

...e/src/main/java/javasabr/mqtt/auth/service/config/DatabaseCredentialsSourceSpringConfig.java

+  @Bean(initMethod = "migrate")
+  Flyway credentialsSourceFlyway(
+      DatabaseConnectionProperties databaseCredentialsSourceProperties,
+      DatabaseCredentials adminDatabaseCredentials) {


@crazyrokr on your branch I cannot start the broker app:
Factory method 'authenticationService' threw exception with message: Authenticator providers are not configured

…Test

…lyway

Copilot

Pull request overview

This PR implements a comprehensive authentication service architecture for the MQTT broker, replacing the simple file-based authentication with a modular, extensible system supporting multiple authentication providers and credentials sources. It also introduces Flyway for database schema versioning.

Changes:

Introduces a modular authentication architecture with 5 new modules (authentication-api, authentication-service, authentication-provider-basic, credentials-source-file, credentials-source-db)
Implements database-backed credentials storage with Flyway migrations for PostgreSQL
Replaces legacy authentication classes in core-service with new API-based implementations

Reviewed changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
settings.gradle	Adds 5 new authentication-related modules to the project
gradle/libs.versions.toml	Adds dependencies for R2DBC, PostgreSQL, Flyway, Testcontainers, and AssertJ
test-support/build.gradle	Adds spring-boot-test and assertj-core for testing support
buildSrc/src/main/groovy/configure-java.gradle	Adds `-parameters` compiler flag for better runtime parameter reflection
base/src/main/java/javasabr/mqtt/base/util/*	Adds PropertyAssert and BrokerConfigurationException for configuration validation
authentication-api/src/main/java/javasabr/mqtt/auth/api/*	Defines core authentication interfaces, DTOs, and enums for the authentication architecture
authentication-service/src/main/java/javasabr/mqtt/auth/service/*	Implements DefaultAuthenticationService with multi-provider support and Spring auto-configuration
authentication-provider-basic/src/main/java/javasabr/mqtt/auth/provider/*	Implements basic username/password authentication with ASCII validation
credentials-source-file/src/main/java/javasabr/mqtt/auth/credentials/source/*	Implements file-based credentials storage with in-memory caching
credentials-source-db/src/main/java/javasabr/mqtt/auth/credentials/source/*	Implements PostgreSQL-backed credentials storage with R2DBC and Flyway
authentication-service/src/main/resources/db/migration/*	Adds Flyway migration for user_credentials table schema
authentication-service/src/test/*	Adds comprehensive integration tests with Testcontainers for database testing
core-service/src/main/java/javasabr/mqtt/service/*	Removes legacy authentication classes (replaced by new authentication-api)
core-service/src/main/java/javasabr/mqtt/service/message/handler/impl/ConnectInMqttInMessageHandler.java	Updates to use new MqttCredentials DTO instead of raw username/password parameters
core-service/build.gradle	Adds dependency on authentication-api module
application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java	Removes local authentication service beans, imports AuthenticationServiceSpringConfig
application/src/main/resources/application.properties	Updates authentication configuration property names
application/src/test/*	Updates test configuration and refactors MQTT client creation into factory class
application/build.gradle	Adds dependencies on authentication-service and credentials-source modules
acl-service/src/main/java/javasabr/mqtt/acl/service/AclEngineBasedAuthorizationService.java	Minor comment grammar fix (unrelated to main feature)

credentials-source-db/src/main/java/javasabr/mqtt/auth/credentials/source/FlywayBuilder.java

...source-db/src/main/java/javasabr/mqtt/auth/credentials/source/DatabaseCredentialsSource.java

authentication-api/src/main/java/javasabr/mqtt/auth/api/AuthenticationMethod.java

authentication-api/src/main/java/javasabr/mqtt/auth/api/database/DatabaseDriver.java

authentication-api/src/main/java/javasabr/mqtt/auth/api/AuthenticationMethod.java

...ntication-service/src/main/java/javasabr/mqtt/auth/service/DefaultAuthenticationService.java

crazyrokr and others added 29 commits December 5, 2025 00:01

[broker-67] Add authentications modules and initial class structure

4449b92

[broker-67] Remove unnecessary import

3c353c4

[broker-67] Implement file and db credentials sources

bfef50e

Merge branch 'develop' into feature-broker-67

53b38dc

# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/service/acl/AclRulesLoader.groovy # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java

[broker-67] Rename CredentialsSourceDatabaseConfig

3d36a83

[broker-67] Add tests

fd0835b

[broker-67] Refactoring

0de823c

[broker-67] Introduce AuthenticationSpringConfig

c7c5213

[broker-67] Revert unnecessary changes

388be51

[broker-67] Introduce DatabaseClient from spring-r2dbc

ed00b01

Merge branch 'develop' into feature-broker-67

ebbfc47

[broker-67] Refactoring

ef1f19b

[broker-67] Make AuthRequest a record

9239636

reorganize ACL modules

b75fd79

reorganize ACL modules

8fe507c

reorganize ACL modules

5bcdcd1

integrate configuring groovy acl for application

f3fd5c7

integrate configuring groovy acl for application

cfe73ce

resolve review comments

63c300c

Merge branch 'develop' into feature-broker-67

63ab62d

Merge branch 'feature/142-integrate-acl-groovy-based-engine-part-1' i…

aceb2f7

…nto feature/142-integrate-acl-groovy-based-engine-part-2

Merge remote-tracking branch 'origin/develop' into feature/142-integr…

e34f937

…ate-acl-groovy-based-engine-part-2

Merge branch 'develop' into feature-broker-67

7f4768f

# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/acl/groovy/dsl/loader/AclRulesLoader.groovy

resolve code review comments

59dabc4

Merge branch 'feature-broker-67' into feature/141-implement-db-vesion…

307655f

…ing-with-flyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

Merge branch 'develop' into feature-broker-67

74bb96a

# Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

Merge branch 'develop' into feature/141-implement-db-vesioning-with-f…

faecf1a

…lyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

[broker-141] Introduce Flyway

f1bd443

Merge branch 'feature-broker-67' into feature/141-implement-db-vesion…

c7ae159

…ing-with-flyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle

crazyrokr linked an issue Dec 20, 2025 that may be closed by this pull request

Implement DB vesioning with Flyway #141

Closed

crazyrokr added 2 commits January 12, 2026 01:06

[broker-141] Introduce PropertyAssert

8bb6c58

[broker-141] Move InMemoryCredentialsSource to credentials-source-file

b7526ba

JavaSaBr reviewed Jan 13, 2026

View reviewed changes

crazyrokr added 9 commits January 13, 2026 13:18

[broker-141] Optimize DatabaseCredentialsSource query

df14a98

[broker-141] Move PropertyAssert to base module

f9ac55d

[broker-141] Rename databaseCredentialsSourceProperties autowired can…

6cb6f30

…didate

[broker-141] Rename DatabaseCredentialsSourceBuilder

c05fea4

[broker-141] Separate Flyway and DatabaseCredentialsSource builders

1b3875d

[broker-141] Remove unnecessary log4j2.xml

3bc1bdd

[broker-141] Move PostgreSQLContainer to Spring cpnfig

c169ca9

[broker-141] Improve logging

09568c2

[broker-141] Improve logging and naming

1b544a9

JavaSaBr reviewed Jan 14, 2026

View reviewed changes

crazyrokr added 6 commits January 15, 2026 13:52

[broker-141] Refactoring

98f3cd2

[broker-141] Initialize FileCredentialsSource in constructor

bea0179

[broker-141] Introduce NoOpAuthenticationService

56cc9f1

[broker-141] Replace EmptyProviderTest with NoOpAuthenticationService…

aac1ce9

…Test

[broker-141] Rename method

51d3462

Merge branch 'develop' into feature/141-implement-db-vesioning-with-f…

a8bbfec

…lyway

JavaSaBr requested a review from Copilot January 18, 2026 12:49

Copilot started reviewing on behalf of JavaSaBr January 18, 2026 12:50 View session

Copilot AI reviewed Jan 18, 2026

View reviewed changes

credentials-source-db/src/main/java/javasabr/mqtt/auth/credentials/source/FlywayBuilder.java Show resolved Hide resolved

...source-db/src/main/java/javasabr/mqtt/auth/credentials/source/DatabaseCredentialsSource.java Show resolved Hide resolved

[broker-141] Make database migration location configurable

b391f93

crazyrokr requested a review from JavaSaBr January 18, 2026 13:35

JavaSaBr reviewed Jan 18, 2026

View reviewed changes

crazyrokr added 2 commits January 18, 2026 15:20

[broker-141] Improve enum API

e059fbe

[broker-141] Use method reference for log printing

27e6e83

JavaSaBr approved these changes Jan 18, 2026

View reviewed changes

crazyrokr merged commit ccc2dbf into develop Jan 18, 2026
6 checks passed

crazyrokr deleted the feature/141-implement-db-vesioning-with-flyway branch January 18, 2026 15:36

#67+#141 Implement Authentication Service and DB versioning with Flyway #145

#67+#141 Implement Authentication Service and DB versioning with Flyway #145

Uh oh!

Conversation

crazyrokr commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazyrokr Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

crazyrokr commented Dec 20, 2025 •

edited

Loading

crazyrokr Jan 14, 2026 •

edited

Loading