Skip to content

feature: [149] Update implementation of MQTT session lifecycle, part 1 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JavaSaBr merged 12 commits into from
Jan 7, 2026
Merged

feature: [149] Update implementation of MQTT session lifecycle, part 1 #151

JavaSaBr merged 12 commits into from
Jan 7, 2026

Conversation

@JavaSaBr
Copy link
Owner

@JavaSaBr JavaSaBr commented Dec 29, 2025 •
edited
Loading

#149

Update implementation of MQTT session lifecycle, part 1:

  1. Split sessions states in InMemorySessionService: [active sessions, expirable, not expirable)
  2. Update creating/storing/restoring sessions implementation to avoid any race conditions
  3. Update ConnectInMqttMessage to follow specs: update reading main fields, properties, will properties
    and add validation.
  4. Update default session expiry interval: No any defaults on the server side (dropped the property), for MQTT 3.1.1 default is infinity, for MQTT 5.0 default is 0

@JavaSaBr JavaSaBr requested a review from crazyrokr December 29, 2025 19:33
@JavaSaBr JavaSaBr self-assigned this Dec 29, 2025
@JavaSaBr JavaSaBr added the core label Dec 29, 2025
@JavaSaBr
small fix
cf60304
@JavaSaBr
Merge remote-tracking branch 'origin/develop' into feature/149-update…
879e76b 
…-mqtt-session-live-cycle

# Conflicts:
#	application/src/test/groovy/javasabr/mqtt/broker/application/PublishRetryTest.groovy
@github-actions
Copy link

github-actions bot commented Dec 29, 2025 •
edited
Loading

Test Coverage Report

Overall Project 85.78% -1.82% 🍏
Files changed 78.05% 🍏

File Coverage
ConnectAckMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
MqttClientConnectionConfig.java 100% 🍏
MqttProperties.java 100% 🍏
MqttServerConnectionConfig.java 100% 🍏
MqttVersion.java 98.22% -0.59% 🍏
FieldsValidatedMqttInMessageHandler.java 97.75% 🍏
DisconnectMqttInMessage.java 94.29% 🍏
ClientIdMqttInMessageFieldValidator.java 93.75% -6.25% 🍏
InMemoryNetworkMqttSession.java 93.75% 🍏
Mqtt5MessageOutFactory.java 91.67% 🍏
MqttBrokerSpringConfig.java 89.61% 🍏
ConnectMqttInMessage.java 89.11% -9.78% 🍏
MqttInMessage.java 87.94% 🍏
DefaultPublishDeliveringService.java 84.47% 🍏
DefaultMessageOutFactoryService.java 82.39% 🍏
DebugUtils.java 80.29% 🍏
ConnectMqtt5OutMessage.java 80.25% 🍏
AbstractNetworkMqttUserReleaseHandler.java 78.26% -20% ❌
ConnectInMqttInMessageHandler.java 75.33% -5.24% 🍏
Mqtt311MessageOutFactory.java 69.12% 🍏
InMemoryMqttSessionService.java 66.12% -32.51% 🍏
MqttMessageOutFactory.java 66% 🍏
ConnectionRejectException.java 56.25% 🍏

crazyrokr
crazyrokr requested changes Jan 2, 2026
View reviewed changes
crazyrokr
crazyrokr requested changes Jan 2, 2026
View reviewed changes
@crazyrokr crazyrokr linked an issue Jan 3, 2026 that may be closed by this pull request
Update MQTT session live cycle #149
Closed
crazyrokr
crazyrokr requested changes Jan 6, 2026
View reviewed changes
Copy link
Collaborator

@crazyrokr crazyrokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increse test coverage

@JavaSaBr JavaSaBr merged commit 3f19617 into develop Jan 7, 2026
6 checks passed
@JavaSaBr JavaSaBr deleted the feature/149-update-mqtt-session-live-cycle branch January 7, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazyrokr crazyrokr crazyrokr approved these changes

Assignees

@JavaSaBr JavaSaBr

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update MQTT session live cycle

3 participants

@JavaSaBr @crazyrokr