Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified develop_academy.sh #2466

Open
wants to merge 2 commits into
base: old_manager
Choose a base branch
from

Conversation

vaishnavimulik25
Copy link

In 2465 I faced issue while running develop_academy.sh. Following are the changes that I made.

  1. User Interaction: Added functionality for the user to select Docker actions (start or stop) based on their preference. This improves usability and flexibility, allowing users to manage Docker containers more efficiently.
  2. Dependency Management: Utilized npm install --force to address potential dependency tree issues that could hinder project functionality.

Testing:
Tested the updated script locally to verify that user prompts for Docker actions work as expected.
Verified that dependencies are installed correctly using npm install --force and that the script executes without errors.

working

modified

@OscarMrZ
Copy link
Collaborator

Hi @vaishnavimulik25, thanks for your contrib! Why do you think this interaction is needed exactly? Please describe a usecase.

Currently, thanks to ending the commands with ;, when the user closes the script with Crtl+C, docker-compose down and the rm commands get executed, efectively cleaning the developing environment. The user may start again with the command with no problems.

@vaishnavimulik25
Copy link
Author

Hi @OscarMrZ ,As a user, I encountered a problem where I lacked control over starting, stopping, and restarting Docker. Upon reviewing the script, I realized that I had to run it each time to execute docker-compose up, even when the development environment was already set up. This redundancy posed an inconvenience.

@OscarMrZ
Copy link
Collaborator

Hi @vaishnavimulik25. Why did u need to restart the container so much? The script is intended to prepare a development environment, and then you can edit the code without having to rerun the script or docker-compose up. I think a more interesting approach would be to check if the react frontend should be regenerated (#2470) . While the script will check if the env if setup each time that it is run, it only install the necessary things the first time, so I don't really think a while loop to check for docker reboot is needed, although it is a valid suggestion!

Let me know if u would be interested in working in the mentioned issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants