Run benchmarks on CI #335
Merged
Run benchmarks on CI #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
force-pushed
the
benchmarks-ci
branch
from
5b8b5f8 to
7ea1b22
Compare
How can this prevent performance regressions? |
It naturally doesn't automatically it by itself, but it's a good indicator when reviewing a PR. |
|
@jonkoops sorry, of course you can compare the diff between the two versions from the CI output, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the benchmarks on CI. This is used as a simple smoke test to ensure the benchmarks do not break, and to prevent big regressions from getting introduced by accident.