Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tsd from 0.30.2 to 0.30.3 #356

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 4, 2024

Bumps tsd from 0.30.2 to 0.30.3.

Release notes

Sourced from tsd's releases.

v0.30.3

  • Add code 2561 to known errors (#205) 6896a11

tsdjs/tsd@v0.30.2...v0.30.3

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [tsd](https://github.com/tsdjs/tsd) from 0.30.2 to 0.30.3.
- [Release notes](https://github.com/tsdjs/tsd/releases)
- [Commits](tsdjs/tsd@v0.30.2...v0.30.3)

---
updated-dependencies:
- dependency-name: tsd
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 4, 2024
@dcousens
Copy link
Collaborator

dcousens commented Jan 4, 2024

@jonkoops can we reduce this to

  • at most one weekly lockfile update
  • majors as they appear

@jonkoops
Copy link
Collaborator

jonkoops commented Jan 4, 2024

at most one weekly lockfile update

The lockfile needs to be updated whenever dependencies are updated, so I am not sure what you mean here. I can configure Dependabot to only run updates once a week, if that is what you prefer.

majors as they appear

So you want to always create PRs for major versions? It's possible, I think by specifying a separate range, but we might as well do it once a week, should be no harm in that.

Personally, I don't particularly care, I'll just merge them as they come along, but let me know what you prefer.

@jonkoops jonkoops merged commit 8a5459b into main Jan 4, 2024
5 checks passed
@jonkoops jonkoops deleted the dependabot/npm_and_yarn/tsd-0.30.3 branch January 4, 2024 09:45
@dcousens
Copy link
Collaborator

dcousens commented Jan 6, 2024

The lockfile needs to be updated whenever dependencies are updated, so I am not sure what you mean here.

Yes, but the reverse isn't true. Dependency version ranges don't need to be updated for the lock file to be updated.
Renovate refers to this as lockFileMaintenance, an example configuration I use in other projects.

The end result is, you only need additional pull requests for major version changes, as minor version changes are captured when you update your lock file, assuming you used a ^ or > anyway.

This results in - what should be non-breaking changes - accumulated in one pull request, and breaking changes ready to review in separate pull requests.

@jonkoops
Copy link
Collaborator

jonkoops commented Jan 6, 2024

Yes, but the reverse isn't true. Dependency version ranges don't need to be updated for the lock file to be updated. Renovate refers to this as lockFileMaintenance, an example configuration I use in other projects.

Ahh, yeah that makes sense indeed. It's always good to regenerate the lockfile every once and a while. Unfortunately, I don't believe Dependabot has this functionality, it can be configured to only update the lockfile for the dependencies listed in the package, but it will not update other dependencies in the lockfile.

Personally, I also prefer Renovate, but it requires admin access to add it to the repository, so I just went the path of least resistance and configured Dependabot instead. If you, or @JedWatson can install the Renovate app, we can use it instead.

The end result is, you only need additional pull requests for major version changes, as minor version changes are captured when you update your lock file, assuming you used a ^ or > anyway.

Yeah this is true. I like having both the lockfile and the package be on the latest versions (even if it's a range), hence I configured Dependabot to bump both versions. Either way, this is just a personal preference, and has no functional impact.

If you like we can set up Renovate in a similar manner as your example configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants