Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onTouchEnd target when in a shadow root #5737

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rgripper
Copy link

@rgripper rgripper commented Aug 23, 2023

For any element inside a shadow root event.target points to the shadow root, so a blur event is always evaluated to be outside of the select element. That means the dropdown opens on a touch start and mistakenly closes when the touch ends.

For any element inside a shadow root `event.target` points to the shadow root, so a blur event is always evaluated to be outside of the select element. That means the dropdown opens on a touch start and closes when the touch ends.
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

⚠️ No Changeset found

Latest commit: 8dafd05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8dafd05:

Sandbox Source
react-codesandboxer-example Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant