Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace text 'npm' with 'yarn' #5792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bunnyBites
Copy link

@bunnyBites bunnyBites commented Nov 1, 2023

The build command is for 'yarn', but the label for that command has 'npm', which can be confusing for newcomers (me too). So i have renamed "npm" to "yarn", hope it helps.

yew-npm-to-yarn

Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: cb6b993

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Nov 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb6b993:

Sandbox Source
react-codesandboxer-example Configuration

@csandman
Copy link

csandman commented Jul 4, 2024

That line isn't saying "install it using npm", it's saying "install it from the npm package registry": https://www.npmjs.com/package/react-select

So this change doesn't actually make sense. If anything, it would make more sense to just change the command to include both:

The easiest way to use react-select is to install it from npm and build it into your app with Webpack.

npm install react-select
# or
yarn add react-select

@htech9
Copy link

htech9 commented Sep 22, 2024

It seems that only yarn is referenced everywhere, so it looks like more that the initial PR makes sense.

@JedWatson @gwyneplaine would you confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants