Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d240b39972
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| '("\\.ts\\'" . (lambda () | ||
| (if (fboundp 'typescript-ts-mode) | ||
| (typescript-ts-mode) |
There was a problem hiding this comment.
In Emacs 29+, typescript-ts-mode is defined even if the tree-sitter TypeScript grammar is not installed. This entry only checks fboundp, so opening a .ts file on a machine without the grammar will raise an error and the buffer won’t open, instead of falling back to typescript-mode. Consider checking treesit-ready-p (or handling the error) before calling typescript-ts-mode so users without the grammar can still open .ts files.
Useful? React with 👍 / 👎.
1 participant
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task