Require signed auth for DWS security routes#29
Open
lawyered0 wants to merge 2 commits intoJejuNetwork:mainfrom
Open
Require signed auth for DWS security routes#29lawyered0 wants to merge 2 commits intoJejuNetwork:mainfrom
lawyered0 wants to merge 2 commits intoJejuNetwork:mainfrom
Conversation
Author
|
Why this change: /security routes trusted x-wallet-address alone. That allows any caller to spoof admin actions (WAF rules, API keys, secrets, audit reads). This enforces signed x-jeju-* headers in non-localnet while keeping public WAF reads unchanged. |
Author
|
Follow-up: accept legacy x-wallet-address as the address source for signature validation (still requires x-jeju-timestamp/signature), so existing clients can transition without breaking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- require signed wallet auth headers for /security routes outside localnet\n- keep public WAF reads, but protect all mutation and sensitive read endpoints\n\n## Testing\n- not run (not requested)