Require signed auth for DWS KMS access#34
Open
lawyered0 wants to merge 4 commits intoJejuNetwork:mainfrom
Open
Require signed auth for DWS KMS access#34lawyered0 wants to merge 4 commits intoJejuNetwork:mainfrom
lawyered0 wants to merge 4 commits intoJejuNetwork:mainfrom
Conversation
Author
|
Why this change: KMS routes allowed unauthenticated key/secret listing, key details, and signing. That makes secrets enumerable and signable by anyone. This enforces signed x-jeju-* headers for non-localnet and ensures ownership checks on key/secret access. |
Author
|
Follow-up: close the service-id bypass by requiring a shared service token (KMS_SERVICE_TOKEN / DWS_KMS_SERVICE_TOKEN / SERVICE_AUTH_TOKEN) for x-service-id access outside localnet, and update the local inference provider to send that token. |
Author
|
Follow-up: /kms/vault/diagnostics now requires auth and only returns total secret count for service-id callers. Regular users only see their own count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- require signed wallet auth for KMS key/secret operations outside localnet\n- restrict key and secret listing/details to the authenticated owner\n- enforce owner checks on signing requests\n- require auth for encrypt/decrypt endpoints\n\n## Testing\n- not run (not requested)