Require signed auth for Factory feed and messages#35
Open
lawyered0 wants to merge 1 commit intoJejuNetwork:mainfrom
Open
Require signed auth for Factory feed and messages#35lawyered0 wants to merge 1 commit intoJejuNetwork:mainfrom
lawyered0 wants to merge 1 commit intoJejuNetwork:mainfrom
Conversation
Author
|
Why this change: Factory feed/messages used x-wallet-address alone, so any caller could spoof identity to read messages or post/like/recast/follow as another user. This enforces signed x-jeju-* auth for messages (read/write) and feed writes, adds signed client helpers, and updates CORS to allow the auth headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- enforce signed wallet auth for Factory messages read/write endpoints\n- enforce signed wallet auth for feed write endpoints\n- add signed request helpers + update web hooks to sign messages\n- allow x-jeju-* headers in Factory CORS\n\n## Testing\n- not run (not requested)