fix(typecheck): close auth/sqlit/wallet type and API gaps#39
fix(typecheck): close auth/sqlit/wallet type and API gaps#39Dexploarer wants to merge 1 commit intoJejuNetwork:developfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c955ae4988
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const nonce = bytesToHex(randomBytes(32)) | ||
| const timestamp = Date.now() |
There was a problem hiding this comment.
The external flow rebuilds message with a fresh random nonce/timestamp before checking options.signature, so the second invocation cannot verify the signature from the first invocation's printed message. In the two-step flow (--external --address first, then --external --address --signature), verifyMessage will always fail because the signed payload changed between runs.
Useful? React with 👍 / 👎.
|
|
||
| logger.info('Then run:') | ||
| logger.info( | ||
| `jeju login --network ${network} --address ${address} --signature <your-signature>`, |
There was a problem hiding this comment.
The suggested command omits --external, so users following this prompt run the non-external branch where --signature/--address are ignored and private-key auth is attempted instead. This makes the documented external workflow fail (or authenticate as a different local key if one is configured) even when the user provides a valid external signature.
Useful? React with 👍 / 👎.
1 participant
Summary\n- close auth provider gaps for credential mapping and VC attestation conversion\n- harden passkey response encoding in auth SDK client\n- improve external login flow in CLI with address+signature mode\n- make wallet linked provider typing exclude unsupported email/phone entries\n- harden SQLit row normalization for empty query results\n- add monitoring package dependency on @jejunetwork/auth\n\n## Validation\n- bun run --cwd packages/auth typecheck\n- bun run --cwd packages/sqlit typecheck\n- bun run --cwd apps/wallet typecheck\n- bunx pyright packages/training/python apps/dws/api (pre-existing unrelated errors remain)\n- bun run typecheck:rust