fix: resolve type incompatibilities across zksolbridge docs server#40
fix: resolve type incompatibilities across zksolbridge docs server#40Dexploarer wants to merge 1 commit intoJejuNetwork:developfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b408d78a90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!allowedOrigin) return | ||
| set.headers['Access-Control-Allow-Origin'] = allowedOrigin | ||
| set.headers['Access-Control-Allow-Credentials'] = 'true' | ||
| set.headers['Access-Control-Allow-Headers'] = 'Content-Type' |
There was a problem hiding this comment.
The custom CORS handler now hard-codes Access-Control-Allow-Headers to only Content-Type, which blocks browser preflight for clients that send the standard SDK auth headers (x-jeju-address, x-jeju-timestamp, x-jeju-signature in buildAuthHeaders at packages/sdk/src/a2a/index.ts). In that scenario, requests from otherwise allowed origins are rejected by the browser before POST /api/a2a executes, so this change breaks cross-origin SDK usage of the documentation A2A endpoint.
Useful? React with 👍 / 👎.
1 participant
Summary
@jejunetwork/zksolbridge/teetypes from source in workspace environments.@elysiajs/corsusage in documentation A2A server with local CORS middleware to avoid duplicateelysiatype mismatch.Validation