Fix workspace package typing + docs adapter compatibility#43
Fix workspace package typing + docs adapter compatibility#43Dexploarer wants to merge 7 commits intoJejuNetwork:developfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fceaf5b70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Complete external login with provided signature | ||
| const signature = options.signature | ||
| const isValid = await verifyMessage({ address, message, signature }) | ||
| if (!isValid) { |
There was a problem hiding this comment.
In the --external completion path, verification uses message generated in the current invocation, but that message contains a fresh random nonce/timestamp each run. A signature produced from the message printed in the prior step therefore cannot match here, so the two-step external login flow fails consistently for manual/hardware signing users. Persist and replay the original challenge (or accept the signed message as input) before calling verifyMessage.
Useful? React with 👍 / 👎.
| const authResult = await authenticateWithDWS( | ||
| address, | ||
| signature, | ||
| message, | ||
| network, |
There was a problem hiding this comment.
This branch always calls authenticateWithDWS, but elsewhere in the same command localnet explicitly avoids DWS because it may not be running. As a result, external logins on localnet regress to hard-failing in offline/dev setups even when the signature is valid. Add the same network === 'localnet' token fallback here to preserve existing localnet behavior.
Useful? React with 👍 / 👎.
Dexploarer
changed the title
1 participant
Summary
requestIpresolver in the documentation A2A server to handle adapter API shape changes in Elysia.dist/*.js) so build behavior is preserved.Validation
bun run --cwd apps/documentation typecheck✅bun run --cwd apps/dws typecheckapps/dwsissues unrelated to this change)Updated Files
/Users/home/Downloads/jeju project/apps/documentation/server/a2a-server.ts/Users/home/Downloads/jeju project/packages/api/package.json/Users/home/Downloads/jeju project/packages/auth/package.json/Users/home/Downloads/jeju project/packages/bots/package.json/Users/home/Downloads/jeju project/packages/bridge/package.json/Users/home/Downloads/jeju project/packages/cli/package.json/Users/home/Downloads/jeju project/packages/contracts/package.json/Users/home/Downloads/jeju project/packages/db/package.json/Users/home/Downloads/jeju project/packages/durable-objects/package.json/Users/home/Downloads/jeju project/packages/kms/package.json/Users/home/Downloads/jeju project/packages/solana/package.json/Users/home/Downloads/jeju project/packages/token/package.json/Users/home/Downloads/jeju project/packages/types/package.json/Users/home/Downloads/jeju project/packages/ui/package.json