Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated Error::provide and tests to reflect changes in API #294

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

MegaBluejay
Copy link
Contributor

@MegaBluejay MegaBluejay commented Aug 15, 2023

Synopsis

Update derive and tests to work on the latest nightly with the changes in this PR.

Solution

Use error::{Request, request_ref, request_value} instead of any::{Demand, request_ref, request_value}

Currently request_value is not re-exported from core::error in std::error, which means backtrace tests require #![feature(error_in_core)]

Presumably this is a bug, and will be fixed later

Checklist

  • Documentation is updated (if required)
  • Tests are added/updated (if required)
  • CHANGELOG entry is added (if required)

@MegaBluejay MegaBluejay marked this pull request as ready for review August 15, 2023 11:53
@tyranron tyranron added this to the 1.0.0 milestone Aug 15, 2023
Copy link
Collaborator

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MegaBluejay nice job! Thanks 🍻

@tyranron tyranron merged commit de4f141 into JelteF:master Aug 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants