-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower MSRV to 1.65 #313
Lower MSRV to 1.65 #313
Conversation
The MSRV bump in JelteF#300 is unnecessary. The 1.72 minimum is only needed for tests, but the actual implementation depends on 1.65.
d1df2f3
to
2ce91ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaniPopes thanks for taking care of the details!
@JelteF please, update the required CI jobs in project settings, and merge.
ping @JelteF |
I think it might be nice to have a bit higher MSRV than strictly necessary, because we'll likely keep it the same for the next few years. So I'm not sure we should merge this PR |
@JelteF treating MSRV via SemVer of the crate seems to be quite uncomfortable: either we change the major version when don't really break API, or we are committed to not use newer Rust features until the real API break happens. Considering that MSRV is not that much of the demand for end users (people tend to use newer versions of Rust), we could clearly state (in README) and separate this in the following manner:
|
@JelteF ping |
1 similar comment
@JelteF ping |
I think your proposal sounds good, but we should update the readme accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JelteF I've added "MSRV policy" section to README.
I've also returned running cargo test
in msrv
CI job, because it's vital to check macro expansion too for MSRV. Anything that doesn't fit MSRV from user-side in tests, I've hidden under the #[cfg(not(msrv))]
.
I'll merge this tomorrow, so you can have a look if you want to.
Synopsis
The MSRV bump in #300 is unnecessary. The 1.72 minimum is only needed for tests, but the actual implementation depends on 1.65.
Solution
Lower MSRV from 1.72 to 1.65. Only
build
instead oftest
in MSRV CI job.Checklist