Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type to applyTests function #333

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

arksap2002
Copy link
Collaborator

@arksap2002 arksap2002 commented Aug 30, 2024

Description of changes made

If users cancel the tests applying process, the generated tests tab crashes. The expected behaviour is to close apply tests window only.

Other notes

Closes #326

  • I have checked that I am merging into correct branch

@arksap2002 arksap2002 added bug Something isn't working Urgent Urgant PR Ready for review PR redy for review and removed Urgent Urgant PR labels Aug 30, 2024
@arksap2002 arksap2002 marked this pull request as ready for review August 30, 2024 19:33
@pderakhshanfar pderakhshanfar self-assigned this Sep 17, 2024
@pderakhshanfar pderakhshanfar added the In progress PR is in progress label Sep 17, 2024
@pderakhshanfar
Copy link
Collaborator

@arksap2002 What is the difference between this PR and #331 ? they have the same description

@pderakhshanfar pderakhshanfar removed their assignment Sep 17, 2024
@arksap2002
Copy link
Collaborator Author

@arksap2002 What is the difference between this PR and #331 ? they have the same description

fixed, sorry

Copy link
Collaborator

@Vladislav0Art Vladislav0Art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine. Only one remark about a Javadoc comment.

@arksap2002 arksap2002 merged commit 09ad147 into development Sep 27, 2024
3 checks passed
@arksap2002 arksap2002 deleted the arksap2002/bugs/cancel-tests-applying branch September 27, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working In progress PR is in progress Ready for review PR redy for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test disappear after clicking "cancel" in the applying to project window
3 participants