-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add return type to applyTests function #333
Merged
arksap2002
merged 4 commits into
development
from
arksap2002/bugs/cancel-tests-applying
Sep 27, 2024
Merged
Add return type to applyTests function #333
arksap2002
merged 4 commits into
development
from
arksap2002/bugs/cancel-tests-applying
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arksap2002
added
bug
Something isn't working
Urgent
Urgant PR
Ready for review
PR redy for review
and removed
Urgent
Urgant PR
labels
Aug 30, 2024
@arksap2002 What is the difference between this PR and #331 ? they have the same description |
fixed, sorry |
pderakhshanfar
approved these changes
Sep 17, 2024
Vladislav0Art
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine. Only one remark about a Javadoc comment.
src/main/kotlin/org/jetbrains/research/testspark/display/utils/template/DisplayUtils.kt
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
If users cancel the tests applying process, the generated tests tab crashes. The expected behaviour is to close apply tests window only.
Other notes
Closes #326