test: EXPOSED-229 Fix flaky SQL Server test on TC build #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for JodaTimeDefaultsTest/testDefaultCurrentDateTime()
Add debug output
Adjust TC debug and other module tests
Provide a small epsilon for value comparison initially.
Only use epsilon value for SQL Server. Revert other module tests.
Increase epsilon value
e5l
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test in
exposed-jodatimefails sporadically on TC builds, only on SQL Server:JodaTimeDefaultsTest/testDefaultCurrentDateTime()
Flakiness is not reproducible locally with repeated tests, so the assumption to the cause is:
Hypothesis: Inconsistency with
Thread.sleep?- The test always fails on the first
assertTrueand debug logs used in TC build show that the second inserted value happens +/-10ms around the 2s check.- A 1s epsilon value has been added to a single
Thread.sleepto provide a comparison buffer for SQL Server only.