test: Drop duplicate Spring tests using non-H2 Gradle tasks #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, both spring-transaction and exposed-spring-boot-starter modules are set up to not be database-specific, but to only test how Exposed integrates with Spring. This means that these test classes do not extend DatabaseTestsBase() and all unit tests use an embedded H2 database. In spite of this, all Spring tests are run by every Gradle test task, resulting in multiple H2 duplicate tests when task test or TC build is run. This excludes tests in the Spring package from all tasks except testH2.
Fix spring boot module odd package name in exclude.
bog-walk
commented
Dec 17, 2023
Comment on lines
+65
to
+72
| if (db.ignoresSpringTests) { | ||
| filter { | ||
| // exclude all test classes in (spring-transaction, exposed-spring-boot-starter) modules | ||
| exclude("org/jetbrains/exposed/spring/*", "org/jetbrains/exposed/jdbc-template/*") | ||
| isFailOnNoMatchingTests = false | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
If there is a better gradle way to do this exclusion, please let me know.
e5l
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both
spring-transactionandexposed-spring-boot-startermodules are set up to not be database-specific, but to only test how Exposed generally integrates with Spring.This means that all unit tests use an embedded H2 database and that these test classes do not extend
DatabaseTestsBase().In spite of this, all Spring tests are run by every Gradle test task, resulting in multiple H2 duplicate tests when task
testor TC build is run.Duplicates can be confirmed by:
Transaction.db.vendororTransaction.db.dialectin any test while running a non-H2 test task:exec("SELECT version();")should work when included in any test run withtestPostgres, but instead this is thrown:org.h2.jdbc.JdbcSQLSyntaxErrorException: Function "VERSION" not foundExcluding tests in the Spring packages confirmed locally and on TC build.
The total number of tests is still somehow 10071 but the only tasks with tests is
testH2and build time dropped from 37-40 minutes to 32-35 minutes.Example before:
Example after:
