Skip to content

Allow setting up server port from build tool #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

singleton11
Copy link
Contributor

No description provided.

@@ -1,4 +1,4 @@
version=1.0.0-dev.31.6
version=1.0.0-dev.31.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a left over from local testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it on purpose, thought that it's a good idea to bump version
Gonna remove it though to stick with the default release process

@sellmair
Copy link
Member

Out of curiosity: Why would you need a fixed port, known by the build tool?

@singleton11
Copy link
Contributor Author

singleton11 commented Dec 13, 2024

Out of curiosity: Why would you need a fixed port, known by the build tool?

Because Amper doesn't use recompiler (which now runs Gradle in continuous mode, Amper just has neither the continuous mode nor watching FS abilities), Amper runs agent, compiles, and sends orchestration message itself, instead

So Amper can't communicate with the agent both ways, only from Amper to agent, not vice-versa

UPD: agent could create some file somewhere with the port number used, but setting port number externally was faster to continue prototyping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants