Improve statics re-initialization #59
Conversation
- Statics will only be re-initialized if the clinit method actually changed - Statics will re-initialize in topological dependency order fixes #39
| return try { | ||
| block().toLeft() | ||
| } catch (t: Throwable) { | ||
| if (t is CancellationException) throw t |
There was a problem hiding this comment.
Sorry, you didn't ask, but I got distracted by this lil nitpick, while indeed mostly what you need. There are cases where this might start throwing rogue cancellation exceptions. This becomes increasingly less common in properly structured concurrency (code that does not pass around CoroutineScopes and/or Jobs).
But if you want to be extra safe, you should use ensureActive() here instead.
I usually refer to this read:
https://betterprogramming.pub/the-silent-killer-thats-crashing-your-coroutines-9171d1e8f79b
There was a problem hiding this comment.
That's a good catch. I skimmed over the article and will read it more carefully today evening.
However, since this Try is not a suspend function, I hope that this should just act as 'thin wall' and the rogue cancellation will be handled similar to the Try being absent.
| var index = 0 | ||
|
|
||
| val nodes = mapTo(ArrayList(size * 2)) { value -> Node(value, index++) } |
There was a problem hiding this comment.
Again, not the feedback you asked for 😅, but mapIndexedTo exists :)
| var index = 0 | ||
|
|
||
| val nodes = mapTo(ArrayList(size * 2)) { value -> Node(value, index++) } | ||
| val nodesMap = nodes.associateByTo(LinkedHashMap(nodes.size)) { it.value } |
There was a problem hiding this comment.
No, but interestingly, the benchmark prefers LinkedHashMap here 🤷 That was a surprise to me.
No description provided.