[#159] Changes in core for UI #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pages, dynamic app status
…chats and switching chat mid-query is possible. Also fix a bug with Clean all chats leaving stale links to cache
…rease version 0.1.2->0.1.4dev
…project detection is now CLI's responsibility
23jura23
changed the title
catstrike
reviewed
Feb 13, 2026
Comment on lines
+35
to
+42
| if data_executor is None: | ||
| match executor_type: | ||
| case "react_duckdb": | ||
| data_executor = ReactDuckDBExecutor(writer=writer) | ||
| case "lighthouse": | ||
| data_executor = LighthouseExecutor(writer=writer) | ||
| case _: | ||
| raise ValueError(f"Invalid executor type: {executor_type}") |
Collaborator
There was a problem hiding this comment.
This should happen outside of agent function and the appropriate Executor should be passed as data_executor parameter.
| output will be written to this writer instead of stdout. | ||
| """ | ||
| self._graph_recursion_limit = 50 | ||
| self._writer = writer |
Collaborator
There was a problem hiding this comment.
self._writer is not used in the base class (GraphExecutor). I don't think it should be a part of it.
| class LighthouseExecutor(GraphExecutor): | ||
| def __init__(self) -> None: | ||
| super().__init__() | ||
| def __init__(self, writer: Any = None) -> None: |
Collaborator
There was a problem hiding this comment.
I think the writer should not be stored in Executor. Thread calls execute(...) and already passes the writer. The writer is basically the way to output the result of the query
| stream_plot: bool = False, | ||
| lazy_threads: bool = False, | ||
| auto_output_modality: bool = True, | ||
| writer: TextIO | None = None, |
Collaborator
There was a problem hiding this comment.
I don't think we need to store the writer in the agent. I believe it should be a part of the Thread only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.