Skip to content

Conversation

@hsestupin
Copy link

The idea is to not rely on any imports other than from the root databao_context_engine package

The idea is to not rely on any imports other than from the root `databao_context_engine` package

Signed-off-by: Sergey Stupin <sergey.stupin@jetbrains.com>
@hsestupin hsestupin requested a review from a team February 12, 2026 10:34
@staticmethod
def get_dce_project(project_dir: Path) -> DatabaoContextProjectManagerApi:
if not is_project_dir_valid(project_dir):
raise ValueError(f"No DCE project exists in the directory '{project_dir}'")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DatabaoContextProjectManager constructor throws ValueError already in case the project dir is invalid.
If you would like to have more precise control on the error message we can make is_project_dir_valid public (put it into the root package)

Signed-off-by: Sergey Stupin <sergey.stupin@jetbrains.com>
@SokolovYaroslav SokolovYaroslav requested a review from a team February 12, 2026 10:41
@SokolovYaroslav
Copy link
Collaborator

@hsestupin our team has name "databao-agent", please remove folks from "data-agents" :)

Signed-off-by: Sergey Stupin <sergey.stupin@jetbrains.com>
@hsestupin
Copy link
Author

If you are talking about https://github.com/orgs/JetBrains/teams/data-agents I'm not the owner of this group.

Also I didn't ask this group to look at this PR. Github has requested this group automatically.

@Veirisa
Copy link
Member

Veirisa commented Feb 12, 2026

I moved the DCE update to 0.2.0 into this PR:
#194
@hsestupin Thank you! :)

@Veirisa Veirisa closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants