Added kotlin compiler arguments support #872
Conversation
| KotlinTranslatableCompiler.JS -> kotlinProjectExecutor.convertToJsIr(project) | ||
| KotlinTranslatableCompiler.WASM -> kotlinProjectExecutor.convertToWasm(project, debugInfo) | ||
| KotlinTranslatableCompiler.COMPOSE_WASM -> kotlinProjectExecutor.convertToWasm(project, debugInfo) | ||
| class CompilerRestController( |
There was a problem hiding this comment.
@zoobestik please, check the contract of this controller. If it suits you.
| internal const val WASM_DEFAULT_MODULE_NAME = "playground" | ||
|
|
||
| @Component | ||
| class CompilerArgumentsUtil( |
There was a problem hiding this comment.
@Tapchicoma could you please assist in reviewing this class
There was a problem hiding this comment.
I mean, mainly white lists of arguments, should we remove something, or add
There was a problem hiding this comment.
I also wonder about the hierarchy for WASM and JS. It seems that for WASM and the compose WASM build, we still need some arguments from the JS list.
I don't have much experience with WASM and JS, but it seems that either we have some mistakes in using it, or you have a mistake with grouping WASM and JS args.
There was a problem hiding this comment.
Regarding Wasm - JS arguments - I would propose to talk about it with Zalim
dkrasnoff
force-pushed
the
dkrasnov/KTL-724-provide-the-opportunity-to-pass-kotlin-compiler-arguments
branch
2 times, most recently
from
26d34af to
5809835
Compare
dkrasnoff
force-pushed
the
kotlin-community/dev
branch
from
8fd7307 to
4f2f724
Compare
We are using `kotlin-compiler-arguments-description` maven dependency for extracting all known compiler arguments for the current kotlin version. We've added an endpoint for getting all known compiler dependencies by the given platform. We've extended `run` and `translate` endpoints with the user's compiler args.
dkrasnoff
force-pushed
the
dkrasnov/KTL-724-provide-the-opportunity-to-pass-kotlin-compiler-arguments
branch
from
5809835 to
4dd02f7
Compare
No description provided.