Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new example #16

Merged
merged 7 commits into from
Jun 11, 2024
Merged

feat: add a new example #16

merged 7 commits into from
Jun 11, 2024

Conversation

xXenvy
Copy link
Contributor

@xXenvy xXenvy commented May 31, 2024

This pull request introduces a new example to the lib. The purpose of this demo is to illustrate the automatic generation of setter and getter methods for private fields.

@xXenvy xXenvy changed the title new: usr: add new example feat: add new example May 31, 2024
@xXenvy xXenvy changed the title feat: add new example feat: add a new example May 31, 2024
@JhnW
Copy link
Owner

JhnW commented Jun 2, 2024

Maybe change example name (folder) to getters _generated or, even better, accessor.

@JhnW
Copy link
Owner

JhnW commented Jun 2, 2024

Please check doc_src/demos/ folder and please add your own doc for demo. From what I remember, just adding a file is enough, but if necessary, check the local documentation generation.

@JhnW
Copy link
Owner

JhnW commented Jun 2, 2024

Please check why output does not generate comments with correct spacing.

examples/access_generator/main.py Outdated Show resolved Hide resolved
examples/access_generator/main.py Outdated Show resolved Hide resolved
examples/access_generator/main.py Outdated Show resolved Hide resolved
@xXenvy
Copy link
Contributor Author

xXenvy commented Jun 2, 2024

Please check doc_src/demos/ folder and please add your own doc for demo. From what I remember, just adding a file is enough, but if necessary, check the local documentation generation.

Done.

@xXenvy
Copy link
Contributor Author

xXenvy commented Jun 2, 2024

Maybe change example name (folder) to getters _generated or, even better, accessor.

I changed to accessors_generator. In my opinion, it is ok.

@xXenvy xXenvy requested a review from JhnW June 2, 2024 21:31
examples/accessors_generator/input/car.h Outdated Show resolved Hide resolved
examples/accessors_generator/main.py Outdated Show resolved Hide resolved
@JhnW JhnW merged commit 192581b into JhnW:main Jun 11, 2024
4 of 5 checks passed
@xXenvy xXenvy deleted the feat/example branch June 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants