Skip to content

Commit

Permalink
Add info regarding tests, lint, and checkstyle (firebase#509)
Browse files Browse the repository at this point in the history
  • Loading branch information
SUPERCILEX authored and samtstern committed Jan 10, 2017
1 parent dd6dd6a commit 1a6f7bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ Feature parity (where it makes sense) is a strict requirement for feature develo
### Code reviews

All submissions, including submissions by project members, require review. We
use Github pull requests for this purpose. We adhere to the
use GitHub pull requests for this purpose. We adhere to the
[Google Java style guide](https://google.github.io/styleguide/javaguide.html).
In addition, style and lint checks are run on each Travis build to ensure quality. To run the full
suite of tests, checks, lint, etc, use `./gradlew check` (this will ensure the Travis build passes).

### The small print

Expand Down
1 change: 1 addition & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

* Read [the contribution guidelines](CONTRIBUTING.md).
* Run `./gradlew check` to ensure the Travis build passes.
* If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
* If this is a new feature please co-ordinate with someone on [FirebaseUI-iOS](https://github.com/firebase/firebaseui-ios) to make sure that we can implement this on both platforms and maintain feature parity.

0 comments on commit 1a6f7bb

Please sign in to comment.