-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial submissions #705
Open
chiragchhatrala
wants to merge
24
commits into
main
Choose a base branch
from
627a0-partial-submissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Partial submissions #705
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c3d0596
Implement partial form submissions feature
chiragchhatrala a0c5b92
Add status filtering for form submissions
chiragchhatrala cfcc364
Add Partial Submission in Analytics
chiragchhatrala 00053cd
improve partial submission
chiragchhatrala 1a96a84
fix lint
chiragchhatrala fb010a6
Add type checking for submission ID in form submission job
chiragchhatrala 8e85ca8
Merge branch 'main' into 627a0-partial-submissions
chiragchhatrala e4d0f13
on form stats Partial Submissions only if enable
chiragchhatrala 33c1c86
Partial Submissions is PRO Feature
chiragchhatrala 2b5c0fe
Partial Submissions is PRO Feature
chiragchhatrala e4a3d78
improvement migration
chiragchhatrala 8b01f70
Update form submission status labels to 'Submitted' and 'In Progress'
chiragchhatrala e196f95
start partial sync when dataFormValue update
chiragchhatrala 7629f3b
badge size xs
chiragchhatrala a8112e2
Refactor partial submission hash management
chiragchhatrala 232d612
Merge branch 'main' into 627a0-partial-submissions
chiragchhatrala ca0524c
Refactor partial form submission handling in PublicFormController
chiragchhatrala f279b87
fix submissiona
chiragchhatrala 2cb9139
Refactor form submission ID handling and metadata processing
JhumanJ ce1e21d
Enhance form submission settings UI with advanced partial submission …
JhumanJ d0f73cf
Refactor partial form submission sync mechanism
JhumanJ 52c5812
Merge branch 'main' into 627a0-partial-submissions
chiragchhatrala d3959f6
Improve partial form submission validation and synchronization
chiragchhatrala b5914fc
fix lint
chiragchhatrala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
❓ Verification inconclusive
Verify FormSubmission status constants and add error handling.
The code assumes the existence of
FormSubmission::STATUS_COMPLETED
andFormSubmission::STATUS_PARTIAL
constants. Additionally, database queries should include error handling.Add try-catch blocks for database queries:
🏁 Script executed:
Length of output: 119
Verify FormSubmission Constants and Add Error Handling
FormSubmission
class defines bothSTATUS_COMPLETED
andSTATUS_PARTIAL
constants. Our initial AST search did not return output—use a text search (e.g., withrg
) to confirm their existence.To further assist verification, you may run:
Please ensure these changes align with your codebase before merging.
🏁 Script executed:
Length of output: 1713
Constants Verified – Please Add Error Handling to Database Queries
The status constants
FormSubmission::STATUS_COMPLETED
andFormSubmission::STATUS_PARTIAL
have been confirmed inapi/app/Models/Forms/FormSubmission.php
. Since these constants exist, the primary focus should be on enhancing the robustness of the database queries by wrapping them in a try-catch block, as outlined below:FormSubmission::STATUS_COMPLETED
exists.FormSubmission::STATUS_PARTIAL
exists.Please update your code as follows:
Please verify that the try-catch implementation aligns with your overall error handling strategy before merging.
📝 Committable suggestion