Skip to content

Fix to Mailchimp failing to respond to Expect: 100-Continue headers #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix to Mailchimp failing to respond to Expect: 100-Continue headers #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dba2c59
Overwrite Expect header with empty Expect value, which removes it.
rkingy Jul 6, 2022
71cd7e3
Remove error logging from Test
rkingy Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Requests/MailchimpRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ public function getHeaders()
if (!is_array($this->headers)) {
throw new MailchimpException("Request headers must be of type array");
}
$this->headers[] = 'Expect:';
return $this->headers;
}

Expand Down
7 changes: 7 additions & 0 deletions tests/UtilityTests/MailchimpRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ public function testAuthHeadersSet()
self::assertEquals($expected, $actual, "Auth Header should be appropriately set");
}

public function testExpectHeaderNotSet()
{
$expected = 'Expect:';
$actual = $this->requestInstance->getHeaders()[1];
self::assertEquals($expected, $actual, "Expect header should be empty");
}

public function testApikeySet()
{
self::assertEquals(
Expand Down