Skip to content

Conversation

@K-Suzuki-Jij
Copy link
Contributor

変更

このPRで熱浴法の実装をGumbel-Max Trickから累積和を直接計算する実装にしました。しかし、特定のケースで確率分布の計算でオーバーフローしてsegmentation faultとなることがわかりました。なのでGumbel-Max Trickを使った実装に戻しました。

Copilot AI review requested due to automatic review settings October 13, 2025 02:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the heat-bath method implementation from a direct cumulative sum calculation back to the Gumbel-Max Trick approach due to segmentation faults caused by overflow in probability distribution calculations.

  • Replaces cumulative probability distribution calculation with Gumbel-Max Trick sampling
  • Removes partition function calculation and cumulative probability tracking
  • Implements random variable generation using double logarithm for Gumbel distribution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@K-Suzuki-Jij K-Suzuki-Jij requested a review from j-i-k-o October 13, 2025 03:02
Copy link
Collaborator

@j-i-k-o j-i-k-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #496 との差分を確認しました。

@K-Suzuki-Jij K-Suzuki-Jij merged commit 1f11ae4 into main Oct 13, 2025
20 checks passed
@K-Suzuki-Jij K-Suzuki-Jij deleted the hotfix/heat-bath-segf branch October 13, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants