QPLIB format parser #250
QPLIB format parser #250
Conversation
| // a little hack to allow us to add the line numbers | ||
| // as context to errors generated in `FromStr` impls | ||
| #[error("{inner} (at line {line_num})")] | ||
| WithLine { | ||
| line_num: usize, | ||
| inner: Box<QplibParseError>, | ||
| }, |
There was a problem hiding this comment.
It would be better to convert WithLine as ParseError type, and other entries as separated enum, e.g. ParseErrorReason.
| #[error(transparent)] | ||
| ParseFloat(#[from] std::num::ParseFloatError), | ||
| #[error(transparent)] | ||
| Io(#[from] std::io::Error), |
There was a problem hiding this comment.
IO error is not a parse error. Since std::io::Error does not contains which file is tried to opened, returning this error is not user-friendly. We should rather return anyhow::Result from function which may returns IO error with anyhow::Context to tell which file is opened.
For the actual parse errors like invalid var types, creating this ParseError and returned within anyhow::Error. Users can get the error as ParseError via downcast https://docs.rs/anyhow/latest/anyhow/struct.Error.html#method.downcast
There was a problem hiding this comment.
Similar to MPS, we want to create some cases which is invariant via the round-trip ommx.v1.Instance -> QPLIB format -> ommx.v1.Instance. Do you have any idea especially for ID mapping.
Adds the ability to read QPLIB files to create OMMX instances.
Some consideration has been given to adding the ability to output QPLIB format in the future but some aspects of it are still open.