Skip to content

Commit

Permalink
fix: coil load image with original size (#217)
Browse files Browse the repository at this point in the history
* fix: coil load image use the original dimensions by default

* fix: remove expo android ios folders and ignore it

* chore: update dependecies and ci

* chore: release 1.2.6

* chore: rm podfile.lock
  • Loading branch information
JimmyDaddy authored Feb 4, 2024
1 parent 27b6f40 commit d6e8744
Show file tree
Hide file tree
Showing 79 changed files with 28 additions and 4,738 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
name: Android Test
strategy:
matrix:
api-level: [24, 30, 31]
api-level: [24, 31]
target: [default]
steps:
- name: Checkout the code
Expand Down
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@


## [1.2.6](https://github.com/JimmyDaddy/react-native-image-marker/compare/v1.1.8...v1.2.6) (2024-02-04)


### Bug Fixes

* coil load image use the original dimensions by default ([fc29a6a](https://github.com/JimmyDaddy/react-native-image-marker/commit/fc29a6ac4c55e994863bd32d8b32e7414be0d378))

### Other Changes

* remove expo android ios folders and ignore it ([7cd0df2](https://github.com/JimmyDaddy/react-native-image-marker/commit/7cd0df272e516a18cacea6f4d8114ad14c36f769))


## [1.2.5](https://github.com/JimmyDaddy/react-native-image-marker/compare/v1.2.4...v1.2.5) (2024-01-26)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import coil.decode.GifDecoder
import coil.decode.ImageDecoderDecoder
import coil.decode.SvgDecoder
import coil.request.ImageRequest
import coil.size.Size
import com.facebook.react.bridge.ReactApplicationContext
import com.jimmydaddy.imagemarker.base.Constants.IMAGE_MARKER_TAG
import com.jimmydaddy.imagemarker.base.ErrorCode
Expand Down Expand Up @@ -56,6 +57,8 @@ class MarkerImageLoader(private val context: ReactApplicationContext, private va
if (img.src != null && img.src.width > 0 && img.src.height > 0) {
request = request.size(img.src.width, img.src.height)
Log.d(IMAGE_MARKER_TAG, "src.width: " + img.src.width + " src.height: " + img.src.height)
} else {
request = request.size(Size.ORIGINAL)
}
imageLoader.enqueue(request.target (
onStart = { _ ->
Expand Down
1 change: 1 addition & 0 deletions example/ios/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Podfile.lock
12 changes: 2 additions & 10 deletions example/ios/ImageMarkerExample.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -540,11 +540,7 @@
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
);
OTHER_LDFLAGS = (
"$(inherited)",
"-Wl",
"-ld_classic",
);
OTHER_LDFLAGS = "$(inherited)";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
USE_HERMES = true;
Expand Down Expand Up @@ -611,11 +607,7 @@
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
);
OTHER_LDFLAGS = (
"$(inherited)",
"-Wl",
"-ld_classic",
);
OTHER_LDFLAGS = "$(inherited)";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
USE_HERMES = true;
Expand Down
Loading

0 comments on commit d6e8744

Please sign in to comment.